Re: [PR] Enable native MSE planning for SUM/AVG over MV columns and drop broker rewrite [pinot]

["noob-se7en (via GitHub)" <gi...@apache.org>]

noob-se7en commented on code in PR #18379:
URL: https://github.com/apache/pinot/pull/18379#discussion_r3174538008


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -1072,9 +1053,6 @@ private CompileResult compileRequest(long requestId, String query, SqlNodeAndOpt
     }
 
     Schema schema = _tableCache.getSchema(rawTableName);
-    if (schema != null) {
-      handleAggFunctionMVOverride(serverPinotQuery, schema);
-    }
     _queryOptimizer.optimize(serverPinotQuery, schema);

Review Comment:
   the deleted broker rewrite covered 14 functions (count/min/max/sum/avg/distinctcount* family/minmaxrange/distinctsum/distinctavg) but this PR only adds native MSE handling for SUM and AVG. are the other 12 already MV-aware on both SSE and MSE paths? if #17061 fully consolidated them this is just cleanup, but if not it's a silent SSE regression for `COUNT(mvCol)` etc. worth calling out in the description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org