[GitHub] john-bodley opened a new pull request #6845: [main] Disable resetting main DB attributes

[GitBox <gi...@apache.org>]

john-bodley opened a new pull request #6845: [main] Disable resetting main DB attributes
URL: https://github.com/apache/incubator-superset/pull/6845
 
 
   This PR resolves an issue where if you re-run `superset init` the main database resets the following attributes to true:
   - `allow_csv_upload`
   - `expose_in_sqllab`
   
   If the database exists I sense one shouldn't changes these attributes (we've run into issues were users have uploaded CSV files to the main database) which was possible after every deploy (which runs the `superset init` command). 
   
   Additionally I set the defaults to false for both these attributes because i) one could argue that exposing the main DB in SQL Lab is a potential security vulnerability, and ii) one probably shouldn't upload CSV files to Superset's main database.
   
   to: @graceguo-supercat @michellethomas @mistercrunch @timifasubaa @youngyjd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org