You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Ralph Goers <ra...@dslextreme.com> on 2014/04/21 08:05:08 UTC
Unit test failures
I just did a fresh checkout and am getting the following test failures:
Results :
Failed tests:
CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
FileOutputTest.testConfig:44 File is empty
Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
It's specified in the pluginManagement section now. I might have changed
that when I was cleaning up the OSGi stuff.
On 27 April 2014 15:15, Ralph Goers <ra...@dslextreme.com> wrote:
> I thought they all did - or it used to be in the parent pom.
>
> Ralph
>
> On Apr 27, 2014, at 12:57 PM, Matt Sicker <bo...@gmail.com> wrote:
>
> Done. Looks like any jar-type project needs to include the
> maven-bundle-plugin in their build section.
>
> <plugin>
> <groupId>org.apache.felix</groupId>
> <artifactId>maven-bundle-plugin</artifactId>
> </plugin>
>
>
>
> On 27 April 2014 14:55, Matt Sicker <bo...@gmail.com> wrote:
>
>> On it.
>>
>>
>> On 27 April 2014 14:48, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> OK, but now the Flume samples are failing with the same error. Do you
>>> think you could run the full build and get it to work?
>>>
>>> Ralph
>>>
>>> On Apr 27, 2014, at 12:40 PM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>> Fixed it.
>>>
>>>
>>> On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>>> Now that's a weird one. I'll figure that out right after I finish
>>>> running the log4j-core unit tests before a new commit.
>>>>
>>>>
>>>> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>
>>>>> <sigh>
>>>>>
>>>>> Now the build is failing in the taglib project due to a missing
>>>>> MANIFEST.MF, which I find unusual because the jar plugin normally creates
>>>>> that.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> FileOutputTest was failing because the status level was changed to OFF
>>>>> and the test is expecting status logs to be written to a file. I’m not
>>>>> sure how why this commit was ever done since a “mvn clean install” would
>>>>> have failed. Let me reiterate one more time. If the unit tests fail don’t
>>>>> commit - you did something wrong as the unit tests should ALWAYS pass.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>>
>>>>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> The error in CustomConfigurationTest is now fixed. On to
>>>>> FileOutputTest.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> I finally got a chance to look at CustomConfigurationTest. As I
>>>>> suspected the unit test is incorrect.
>>>>>
>>>>> A check was added to see if the StatusLogger’s level was changed to
>>>>> info. However, setting status=“info” doesn’t change the level of the
>>>>> Logger attached to the status logger. It changes the Level associated with
>>>>> the ConsoleListener added by the configuration. So this error has nothing
>>>>> to do with LOG4J2-607.
>>>>>
>>>>> I should have a fix committed in a little bit.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>>
>>>>> The first unit test failure there is due to LOG4J2-607. The second:
>>>>> not sure.
>>>>>
>>>>>
>>>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com>wrote:
>>>>>
>>>>>> I just did a fresh checkout and am getting the following test
>>>>>> failures:
>>>>>>
>>>>>>
>>>>>> Results :
>>>>>>
>>>>>> Failed tests:
>>>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
>>>>>> not:<INFO>
>>>>>> FileOutputTest.testConfig:44 File is empty
>>>>>>
>>>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <bo...@gmail.com>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>>
>>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
>
--
Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
I thought they all did - or it used to be in the parent pom.
Ralph
On Apr 27, 2014, at 12:57 PM, Matt Sicker <bo...@gmail.com> wrote:
> Done. Looks like any jar-type project needs to include the maven-bundle-plugin in their build section.
>
> <plugin>
> <groupId>org.apache.felix</groupId>
> <artifactId>maven-bundle-plugin</artifactId>
> </plugin>
>
>
>
> On 27 April 2014 14:55, Matt Sicker <bo...@gmail.com> wrote:
> On it.
>
>
> On 27 April 2014 14:48, Ralph Goers <ra...@dslextreme.com> wrote:
> OK, but now the Flume samples are failing with the same error. Do you think you could run the full build and get it to work?
>
> Ralph
>
> On Apr 27, 2014, at 12:40 PM, Matt Sicker <bo...@gmail.com> wrote:
>
>> Fixed it.
>>
>>
>> On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
>> Now that's a weird one. I'll figure that out right after I finish running the log4j-core unit tests before a new commit.
>>
>>
>> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
>> <sigh>
>>
>> Now the build is failing in the taglib project due to a missing MANIFEST.MF, which I find unusual because the jar plugin normally creates that.
>>
>> Ralph
>>
>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> FileOutputTest was failing because the status level was changed to OFF and the test is expecting status logs to be written to a file. I’m not sure how why this commit was ever done since a “mvn clean install” would have failed. Let me reiterate one more time. If the unit tests fail don’t commit - you did something wrong as the unit tests should ALWAYS pass.
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>
>>>>> I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
>>>>>
>>>>> A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
>>>>>
>>>>> I should have a fix committed in a little bit.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>>
>>>>>> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>>>>>>
>>>>>>
>>>>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>>> I just did a fresh checkout and am getting the following test failures:
>>>>>>
>>>>>>
>>>>>> Results :
>>>>>>
>>>>>> Failed tests:
>>>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
>>>>>> FileOutputTest.testConfig:44 File is empty
>>>>>>
>>>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Matt Sicker <bo...@gmail.com>
>>>>>
>>>>
>>>
>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
Done. Looks like any jar-type project needs to include the
maven-bundle-plugin in their build section.
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
</plugin>
On 27 April 2014 14:55, Matt Sicker <bo...@gmail.com> wrote:
> On it.
>
>
> On 27 April 2014 14:48, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> OK, but now the Flume samples are failing with the same error. Do you
>> think you could run the full build and get it to work?
>>
>> Ralph
>>
>> On Apr 27, 2014, at 12:40 PM, Matt Sicker <bo...@gmail.com> wrote:
>>
>> Fixed it.
>>
>>
>> On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
>>
>>> Now that's a weird one. I'll figure that out right after I finish
>>> running the log4j-core unit tests before a new commit.
>>>
>>>
>>> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>>> <sigh>
>>>>
>>>> Now the build is failing in the taglib project due to a missing
>>>> MANIFEST.MF, which I find unusual because the jar plugin normally creates
>>>> that.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com>
>>>> wrote:
>>>>
>>>> FileOutputTest was failing because the status level was changed to OFF
>>>> and the test is expecting status logs to be written to a file. I’m not
>>>> sure how why this commit was ever done since a “mvn clean install” would
>>>> have failed. Let me reiterate one more time. If the unit tests fail don’t
>>>> commit - you did something wrong as the unit tests should ALWAYS pass.
>>>>
>>>> Ralph
>>>>
>>>>
>>>>
>>>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com>
>>>> wrote:
>>>>
>>>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com>
>>>> wrote:
>>>>
>>>> I finally got a chance to look at CustomConfigurationTest. As I
>>>> suspected the unit test is incorrect.
>>>>
>>>> A check was added to see if the StatusLogger’s level was changed to
>>>> info. However, setting status=“info” doesn’t change the level of the
>>>> Logger attached to the status logger. It changes the Level associated with
>>>> the ConsoleListener added by the configuration. So this error has nothing
>>>> to do with LOG4J2-607.
>>>>
>>>> I should have a fix committed in a little bit.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>> The first unit test failure there is due to LOG4J2-607. The second: not
>>>> sure.
>>>>
>>>>
>>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>
>>>>> I just did a fresh checkout and am getting the following test failures:
>>>>>
>>>>>
>>>>> Results :
>>>>>
>>>>> Failed tests:
>>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
>>>>> not:<INFO>
>>>>> FileOutputTest.testConfig:44 File is empty
>>>>>
>>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
On it.
On 27 April 2014 14:48, Ralph Goers <ra...@dslextreme.com> wrote:
> OK, but now the Flume samples are failing with the same error. Do you
> think you could run the full build and get it to work?
>
> Ralph
>
> On Apr 27, 2014, at 12:40 PM, Matt Sicker <bo...@gmail.com> wrote:
>
> Fixed it.
>
>
> On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
>
>> Now that's a weird one. I'll figure that out right after I finish running
>> the log4j-core unit tests before a new commit.
>>
>>
>> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> <sigh>
>>>
>>> Now the build is failing in the taglib project due to a missing
>>> MANIFEST.MF, which I find unusual because the jar plugin normally creates
>>> that.
>>>
>>> Ralph
>>>
>>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>> FileOutputTest was failing because the status level was changed to OFF
>>> and the test is expecting status logs to be written to a file. I’m not
>>> sure how why this commit was ever done since a “mvn clean install” would
>>> have failed. Let me reiterate one more time. If the unit tests fail don’t
>>> commit - you did something wrong as the unit tests should ALWAYS pass.
>>>
>>> Ralph
>>>
>>>
>>>
>>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>>
>>> Ralph
>>>
>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com>
>>> wrote:
>>>
>>> I finally got a chance to look at CustomConfigurationTest. As I
>>> suspected the unit test is incorrect.
>>>
>>> A check was added to see if the StatusLogger’s level was changed to
>>> info. However, setting status=“info” doesn’t change the level of the
>>> Logger attached to the status logger. It changes the Level associated with
>>> the ConsoleListener added by the configuration. So this error has nothing
>>> to do with LOG4J2-607.
>>>
>>> I should have a fix committed in a little bit.
>>>
>>> Ralph
>>>
>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>> The first unit test failure there is due to LOG4J2-607. The second: not
>>> sure.
>>>
>>>
>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>>> I just did a fresh checkout and am getting the following test failures:
>>>>
>>>>
>>>> Results :
>>>>
>>>> Failed tests:
>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
>>>> not:<INFO>
>>>> FileOutputTest.testConfig:44 File is empty
>>>>
>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
>
--
Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
OK, but now the Flume samples are failing with the same error. Do you think you could run the full build and get it to work?
Ralph
On Apr 27, 2014, at 12:40 PM, Matt Sicker <bo...@gmail.com> wrote:
> Fixed it.
>
>
> On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
> Now that's a weird one. I'll figure that out right after I finish running the log4j-core unit tests before a new commit.
>
>
> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
> <sigh>
>
> Now the build is failing in the taglib project due to a missing MANIFEST.MF, which I find unusual because the jar plugin normally creates that.
>
> Ralph
>
> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> FileOutputTest was failing because the status level was changed to OFF and the test is expecting status logs to be written to a file. I’m not sure how why this commit was ever done since a “mvn clean install” would have failed. Let me reiterate one more time. If the unit tests fail don’t commit - you did something wrong as the unit tests should ALWAYS pass.
>>
>> Ralph
>>
>>
>>
>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>>
>>> Ralph
>>>
>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>>
>>>> I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
>>>>
>>>> A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
>>>>
>>>> I should have a fix committed in a little bit.
>>>>
>>>> Ralph
>>>>
>>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>>
>>>>> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>>>>>
>>>>>
>>>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>>>> I just did a fresh checkout and am getting the following test failures:
>>>>>
>>>>>
>>>>> Results :
>>>>>
>>>>> Failed tests:
>>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
>>>>> FileOutputTest.testConfig:44 File is empty
>>>>>
>>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <bo...@gmail.com>
>>>>
>>>
>>
>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
Fixed it.
On 27 April 2014 14:38, Matt Sicker <bo...@gmail.com> wrote:
> Now that's a weird one. I'll figure that out right after I finish running
> the log4j-core unit tests before a new commit.
>
>
> On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> <sigh>
>>
>> Now the build is failing in the taglib project due to a missing
>> MANIFEST.MF, which I find unusual because the jar plugin normally creates
>> that.
>>
>> Ralph
>>
>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> FileOutputTest was failing because the status level was changed to OFF
>> and the test is expecting status logs to be written to a file. I’m not
>> sure how why this commit was ever done since a “mvn clean install” would
>> have failed. Let me reiterate one more time. If the unit tests fail don’t
>> commit - you did something wrong as the unit tests should ALWAYS pass.
>>
>> Ralph
>>
>>
>>
>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>
>> Ralph
>>
>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com>
>> wrote:
>>
>> I finally got a chance to look at CustomConfigurationTest. As I
>> suspected the unit test is incorrect.
>>
>> A check was added to see if the StatusLogger’s level was changed to info.
>> However, setting status=“info” doesn’t change the level of the Logger
>> attached to the status logger. It changes the Level associated with the
>> ConsoleListener added by the configuration. So this error has nothing to
>> do with LOG4J2-607.
>>
>> I should have a fix committed in a little bit.
>>
>> Ralph
>>
>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>> The first unit test failure there is due to LOG4J2-607. The second: not
>> sure.
>>
>>
>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> I just did a fresh checkout and am getting the following test failures:
>>>
>>>
>>> Results :
>>>
>>> Failed tests:
>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
>>> not:<INFO>
>>> FileOutputTest.testConfig:44 File is empty
>>>
>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>>
>>
>>
>>
>>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
Now that's a weird one. I'll figure that out right after I finish running
the log4j-core unit tests before a new commit.
On 27 April 2014 14:30, Ralph Goers <ra...@dslextreme.com> wrote:
> <sigh>
>
> Now the build is failing in the taglib project due to a missing
> MANIFEST.MF, which I find unusual because the jar plugin normally creates
> that.
>
> Ralph
>
> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
> FileOutputTest was failing because the status level was changed to OFF and
> the test is expecting status logs to be written to a file. I’m not sure
> how why this commit was ever done since a “mvn clean install” would have
> failed. Let me reiterate one more time. If the unit tests fail don’t
> commit - you did something wrong as the unit tests should ALWAYS pass.
>
> Ralph
>
>
>
> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>
> Ralph
>
> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com>
> wrote:
>
> I finally got a chance to look at CustomConfigurationTest. As I suspected
> the unit test is incorrect.
>
> A check was added to see if the StatusLogger’s level was changed to info.
> However, setting status=“info” doesn’t change the level of the Logger
> attached to the status logger. It changes the Level associated with the
> ConsoleListener added by the configuration. So this error has nothing to
> do with LOG4J2-607.
>
> I should have a fix committed in a little bit.
>
> Ralph
>
> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>
> The first unit test failure there is due to LOG4J2-607. The second: not
> sure.
>
>
> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> I just did a fresh checkout and am getting the following test failures:
>>
>>
>> Results :
>>
>> Failed tests:
>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
>> not:<INFO>
>> FileOutputTest.testConfig:44 File is empty
>>
>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
>
>
>
>
>
--
Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
<sigh>
Now the build is failing in the taglib project due to a missing MANIFEST.MF, which I find unusual because the jar plugin normally creates that.
Ralph
On Apr 26, 2014, at 10:51 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> FileOutputTest was failing because the status level was changed to OFF and the test is expecting status logs to be written to a file. I’m not sure how why this commit was ever done since a “mvn clean install” would have failed. Let me reiterate one more time. If the unit tests fail don’t commit - you did something wrong as the unit tests should ALWAYS pass.
>
> Ralph
>
>
>
> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>>
>> Ralph
>>
>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>>
>>> I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
>>>
>>> A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
>>>
>>> I should have a fix committed in a little bit.
>>>
>>> Ralph
>>>
>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>>
>>>> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>>>>
>>>>
>>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>>> I just did a fresh checkout and am getting the following test failures:
>>>>
>>>>
>>>> Results :
>>>>
>>>> Failed tests:
>>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
>>>> FileOutputTest.testConfig:44 File is empty
>>>>
>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
FileOutputTest was failing because the status level was changed to OFF and the test is expecting status logs to be written to a file. I’m not sure how why this commit was ever done since a “mvn clean install” would have failed. Let me reiterate one more time. If the unit tests fail don’t commit - you did something wrong as the unit tests should ALWAYS pass.
Ralph
On Apr 26, 2014, at 10:30 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
>
> Ralph
>
> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com> wrote:
>
>> I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
>>
>> A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
>>
>> I should have a fix committed in a little bit.
>>
>> Ralph
>>
>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>>
>>> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>>>
>>>
>>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>>> I just did a fresh checkout and am getting the following test failures:
>>>
>>>
>>> Results :
>>>
>>> Failed tests:
>>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
>>> FileOutputTest.testConfig:44 File is empty
>>>
>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>
>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
The error in CustomConfigurationTest is now fixed. On to FileOutputTest.
Ralph
On Apr 26, 2014, at 10:23 PM, Ralph Goers <ra...@dslextreme.com> wrote:
> I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
>
> A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
>
> I should have a fix committed in a little bit.
>
> Ralph
>
> On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>>
>>
>> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
>> I just did a fresh checkout and am getting the following test failures:
>>
>>
>> Results :
>>
>> Failed tests:
>> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
>> FileOutputTest.testConfig:44 File is empty
>>
>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>
Re: Unit test failures
Posted by Ralph Goers <ra...@dslextreme.com>.
I finally got a chance to look at CustomConfigurationTest. As I suspected the unit test is incorrect.
A check was added to see if the StatusLogger’s level was changed to info. However, setting status=“info” doesn’t change the level of the Logger attached to the status logger. It changes the Level associated with the ConsoleListener added by the configuration. So this error has nothing to do with LOG4J2-607.
I should have a fix committed in a little bit.
Ralph
On Apr 21, 2014, at 12:03 AM, Matt Sicker <bo...@gmail.com> wrote:
> The first unit test failure there is due to LOG4J2-607. The second: not sure.
>
>
> On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
> I just did a fresh checkout and am getting the following test failures:
>
>
> Results :
>
> Failed tests:
> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was not:<INFO>
> FileOutputTest.testConfig:44 File is empty
>
> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
Re: Unit test failures
Posted by Matt Sicker <bo...@gmail.com>.
The first unit test failure there is due to LOG4J2-607. The second: not
sure.
On 21 April 2014 00:05, Ralph Goers <ra...@dslextreme.com> wrote:
> I just did a fresh checkout and am getting the following test failures:
>
>
> Results :
>
> Failed tests:
> CustomConfigurationTest.testConfig:61 expected same:<ERROR> was
> not:<INFO>
> FileOutputTest.testConfig:44 File is empty
>
> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>
--
Matt Sicker <bo...@gmail.com>