You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Thorsten Berger (JIRA)" <je...@portals.apache.org> on 2007/01/02 06:55:27 UTC
[jira] Created: (JS2-637) PortalStatistics: current users count
inaccurate
PortalStatistics: current users count inaccurate
------------------------------------------------
Key: JS2-637
URL: http://issues.apache.org/jira/browse/JS2-637
Project: Jetspeed 2
Issue Type: Bug
Components: Other
Affects Versions: 2.1-dev
Reporter: Thorsten Berger
PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "Thorsten Berger (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12462140 ]
Thorsten Berger commented on JS2-637:
-------------------------------------
David, thanks for the quick response. I had a short look at the source, but I don't believe that the commit resolved this issue.
The current user count is incremented and decremented by logUserLogin() and logUserLogout() and I didn't see any code that could lead to OutOfRangeExceptions there.
But I'll test it in production though and leave a comment here soon.
Regards, Thorsten
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Updated: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "Thorsten Berger (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thorsten Berger updated JS2-637:
--------------------------------
Attachment: currentUserCountFix.txt
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
> Attachments: currentUserCountFix.txt
>
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "David Sean Taylor (JIRA)" <je...@portals.apache.org>.
[ http://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12461797 ]
David Sean Taylor commented on JS2-637:
---------------------------------------
Do you think this could have been fixed with this commit:
http://svn.apache.org/viewvc?view=rev&revision=489379
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: http://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Assigned: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "David Sean Taylor (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor reassigned JS2-637:
-------------------------------------
Assignee: David Sean Taylor
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
> Assigned To: David Sean Taylor
> Attachments: currentUserCountFix.txt
>
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "David Sean Taylor (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464950 ]
David Sean Taylor commented on JS2-637:
---------------------------------------
Im going to leave this open as I believe there still may be other logic where the count gets lost.
Please test and let us know how it is working
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
> Assigned To: David Sean Taylor
> Attachments: currentUserCountFix.txt
>
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Resolved: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "David Sean Taylor (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Sean Taylor resolved JS2-637.
-----------------------------------
Resolution: Fixed
I have been keeping my eye on the statistics for a week or so
Im not seeing the counts going off here
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
> Assigned To: David Sean Taylor
> Attachments: currentUserCountFix.txt
>
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org
[jira] Commented: (JS2-637) PortalStatistics: current users count
inaccurate
Posted by "Thorsten Berger (JIRA)" <je...@portals.apache.org>.
[ https://issues.apache.org/jira/browse/JS2-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464400 ]
Thorsten Berger commented on JS2-637:
-------------------------------------
Unfortunately, it's surely not resolved by the commit. I'm still seeing negative values.
But I think it's caused by Tomcat saving sessions:
After restart, the SessionListener destroys the session and decrements the currentUserCount (which is 0 due to the restart).
What about the following fix?
Regards, Thorsten
> PortalStatistics: current users count inaccurate
> ------------------------------------------------
>
> Key: JS2-637
> URL: https://issues.apache.org/jira/browse/JS2-637
> Project: Jetspeed 2
> Issue Type: Bug
> Components: Other
> Affects Versions: 2.1-dev
> Reporter: Thorsten Berger
> Attachments: currentUserCountFix.txt
>
>
> PortalStatistics.getNumberOfLoggedInUsers() is sometimes inaccurate and even returns negative values.
> Just recognized this as we are showing the current users count in the footer decorator.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org