You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/11 09:30:43 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9279:
[dashboard][api] Fix, PUT publish/draft to not clean slug and owners
dpgaspar opened a new pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279
### CATEGORY
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Fix bug on the dashboard API, "Draft" Button Clears Slug and Owners from Dashboard
### TEST PLAN
Create a new dashboard with a slug and several owners, then publish the dashboard using the dashboard view itself. Verify that slug and owner do not get cleaned
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9279:
[dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r390945610
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,14 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
- data["slug"] = data["slug"].strip()
- data["slug"] = data["slug"].replace(" ", "-")
- data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "slug" in data:
+ data["slug"] = data.get("slug")
+ if data["slug"]:
Review comment:
not exactly, I need to make sure that:
- Exists a slug key?
- If the slug key exists does it have data?
- If the slug key exists and it has data, apply string tranformations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r390966515
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,14 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
- data["slug"] = data["slug"].strip()
- data["slug"] = data["slug"].replace(" ", "-")
- data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "slug" in data:
+ data["slug"] = data.get("slug")
+ if data["slug"]:
Review comment:
Forget it! your right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r390945610
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,14 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
- data["slug"] = data["slug"].strip()
- data["slug"] = data["slug"].replace(" ", "-")
- data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "slug" in data:
+ data["slug"] = data.get("slug")
+ if data["slug"]:
Review comment:
not exactly, I'm need to make sure that:
- Exists a slug key?
- If the slug key exists does it have data?
- If the slug key exists and it has data, apply string tranformations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r390931922
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,14 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
- data["slug"] = data["slug"].strip()
- data["slug"] = data["slug"].replace(" ", "-")
- data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "slug" in data:
+ data["slug"] = data.get("slug")
+ if data["slug"]:
Review comment:
If `"slug" in data`, aren't the next rows unnecessary? Seems like we could just replace these three rows with `if get("slug"):`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9279:
[dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#issuecomment-597551223
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=h1) Report
> Merging [#9279](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/406ad8778c4b83461e534b03d165c279484b2d2c&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9279 +/- ##
=======================================
Coverage 58.90% 58.90%
=======================================
Files 373 373
Lines 12026 12026
Branches 2953 2953
=======================================
Hits 7084 7084
Misses 4763 4763
Partials 179 179
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=footer). Last update [406ad87...126a3eb](https://codecov.io/gh/apache/incubator-superset/pull/9279?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] milimetric commented on issue #9279:
[dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
milimetric commented on issue #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#issuecomment-614755777
We're seeing an issue and it seems related to this change, but I'd like to verify. So the behavior we're seeing is:
* User makes a new dashboard
* Clicks Draft button
* (sometimes) is prompted to log in
* (sometimes) is not prompted to log in
* (always) gets a 401 error with the message {"message":"Access is Denied","severity":"danger"}
Would this be fixed after we get this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9279: [dashboard][api] Fix,
PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391310885
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
@villebro per the [`dict.get`](https://docs.python.org/3/library/stdtypes.html#dict.get) docs, the default is only returned if the key does not exist. I think the desired logic should be,
```python
if "owners" in data and data["owners"] is None:
data["owners"] = []
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391287338
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
I think this is to make sure that `owners` is always a list if the key is present. With the help of these two rows, if `data == {"owners": None}`, `data` becomes `{"owners": []}`, but doesn't get set if `data` doesn't contain the key `owners`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391604137
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
yes, it's better, changed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391415347
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
I agree @john-bodley , this is much more intuitive 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9279: [dashboard][api] Fix,
PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391310885
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
@villebro per the [`dict.get`](https://docs.python.org/3/library/stdtypes.html#dict.get) docs, the default is only returned if the key does not exist. I think the desired logic should be,
```python
if "owners" in data and data["owners"] is None:
data["owners"] = []
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9279: [dashboard][api] Fix,
PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391273225
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
Why are lines 95 - 96 required? If the `owners` key is in `data` then `data.get("owners", [])` is equivalent to `data["owners"]` and thus line 96 becomes `data["owners"] = data["owners"]` which is unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9279: [dashboard][api] Fix,
PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
URL: https://github.com/apache/incubator-superset/pull/9279#discussion_r391310885
##########
File path: superset/views/dashboard/api.py
##########
@@ -88,12 +88,12 @@ class BaseDashboardSchema(BaseOwnedSchema):
@pre_load
def pre_load(self, data): # pylint: disable=no-self-use
super().pre_load(data)
- data["slug"] = data.get("slug")
- data["owners"] = data.get("owners", [])
- if data["slug"]:
+ if data.get("slug"):
data["slug"] = data["slug"].strip()
data["slug"] = data["slug"].replace(" ", "-")
data["slug"] = re.sub(r"[^\w\-]+", "", data["slug"])
+ if "owners" in data:
+ data["owners"] = data.get("owners", [])
Review comment:
@villebro per the [`dict.get`](https://docs.python.org/3/library/stdtypes.html#dict.get) docs, the default is only returned if he key does not exist. I think the desired logic should be,
```python
if "owners" in data and data["owners"] is None:
data["owners"] = []
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] milimetric commented on pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
milimetric commented on pull request #9279:
URL: https://github.com/apache/incubator-superset/pull/9279#issuecomment-644379821
UPDATE: this issue went away when we upgraded to version 0.36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] milimetric commented on pull request #9279: [dashboard][api] Fix, PUT publish/draft to not clean slug and owners
Posted by GitBox <gi...@apache.org>.
milimetric commented on pull request #9279:
URL: https://github.com/apache/incubator-superset/pull/9279#issuecomment-639592488
Gengle ping, can @dpgaspar or anyone else chime in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org