You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Till Toenshoff <to...@me.com> on 2015/07/06 19:12:53 UTC
Review Request 36207: Unified line wrapping for defines in gtest.hpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36207/
-----------------------------------------------------------
Review request for mesos and Alexander Rojas.
Repository: mesos
Description
-------
This updates a bunch of defines within libprocess' gtest.hpp to unify their wrapping towards a consistent style.
Diffs
-----
3rdparty/libprocess/include/process/gtest.hpp 8518c38c9cbf62a098b43b4d0b6d80e561b17ad4
Diff: https://reviews.apache.org/r/36207/diff/
Testing
-------
make check
Thanks,
Till Toenshoff
Re: Review Request 36207: Unified line wrapping for defines in
gtest.hpp.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36207/#review90657
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On July 6, 2015, 7:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36207/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 7:19 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates a bunch of defines within libprocess' gtest.hpp to unify their wrapping towards a consistent style.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 8518c38c9cbf62a098b43b4d0b6d80e561b17ad4
>
> Diff: https://reviews.apache.org/r/36207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 36207: Unified line wrapping for defines in
gtest.hpp.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36207/#review90549
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36207]
All tests passed.
- Mesos ReviewBot
On July 6, 2015, 5:19 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36207/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 5:19 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This updates a bunch of defines within libprocess' gtest.hpp to unify their wrapping towards a consistent style.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp 8518c38c9cbf62a098b43b4d0b6d80e561b17ad4
>
> Diff: https://reviews.apache.org/r/36207/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 36207: Unified line wrapping for defines in
gtest.hpp.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36207/
-----------------------------------------------------------
(Updated July 6, 2015, 5:19 p.m.)
Review request for mesos and Alexander Rojas.
Changes
-------
Fixed ooopsi.
Repository: mesos
Description
-------
This updates a bunch of defines within libprocess' gtest.hpp to unify their wrapping towards a consistent style.
Diffs (updated)
-----
3rdparty/libprocess/include/process/gtest.hpp 8518c38c9cbf62a098b43b4d0b6d80e561b17ad4
Diff: https://reviews.apache.org/r/36207/diff/
Testing
-------
make check
Thanks,
Till Toenshoff