You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/13 02:00:53 UTC
[GitHub] [incubator-nuttx] ttnie opened a new pull request, #7298: install qemu on docker
ttnie opened a new pull request, #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298
Signed-off-by: nietingting <ni...@xiaomi.com>
## Summary
install qemu on docker
## Impact
no
## Testing
test on local host
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie closed pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie closed pull request #7298: install qemu on docker
URL: https://github.com/apache/incubator-nuttx/pull/7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995275448
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +78,15 @@ FROM builder-base AS nuttx-toolchain-base
RUN mkdir /tools
WORKDIR /tools
+# Install dependence package
Review Comment:
move before line 71?
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -209,6 +218,7 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+
Review Comment:
revert the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r994083627
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
+ wget -c "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
update to curl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r994047320
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
+ wget -c "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
why not use curl
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
Review Comment:
move to "Base image" section
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
why not use the latest official release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1278703849
> Something is still wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995492501
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -70,6 +70,9 @@ RUN mkdir -p $CARGO_HOME \
CMD [ "/bin/bash" ]
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
Review Comment:
merge to line 28
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
RUN mkdir /tools
WORKDIR /tools
+# Download and install qemu
+RUN mkdir qemu && \
Review Comment:
move after line 70
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
RUN mkdir /tools
WORKDIR /tools
+# Download and install qemu
+RUN mkdir qemu && \
+ curl -s -L "https://download.qemu.org/qemu-7.1.0.tar.xz" \
+ | tar -C qemu --strip-components 1 -xJ && \
+ cd qemu && ./configure && \
+ make && make install
Review Comment:
need add copy rule in the last section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
btashton commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1280926009
Hmm seems like building qemu is taking a lot of disk space. Do we actually need it to be part of the build image, or should it be a different container? If it was we could just have another job. I'm not sure how qemu was going to be used in CI, but you could have the qemu-test job pull in the build artifacts from the build stage and then not need all the build utilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1280701868
@btashton the storage is still full:
https://github.com/apache/incubator-nuttx/actions/runs/3262925794/jobs/5360800214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995351927
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
RUN mkdir /tools
WORKDIR /tools
+# Download and install qemu
+RUN mkdir qemu && \
+ curl -s -L "https://download.qemu.org/qemu-7.1.0.tar.xz" && \
Review Comment:
```suggestion
curl -s -L "https://download.qemu.org/qemu-7.1.0.tar.xz" \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1277352392
>
rebase the code and trigger ci again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1277311694
@ttnie please rebase the patch, the ci break is fixed here: https://github.com/apache/incubator-nuttx/pull/7299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995399234
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -78,6 +81,13 @@ FROM builder-base AS nuttx-toolchain-base
RUN mkdir /tools
WORKDIR /tools
+# Download and install qemu
+RUN mkdir qemu && \
+ curl -s -L "https://download.qemu.org/qemu-7.1.0.tar.xz" && \
Review Comment:
fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1278566600
Something is still wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
btashton commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1280936210
Another option is to just install the ubuntu packages for qemu. Is there a reason we need to be building it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r994083497
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
Review Comment:
done
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -212,6 +212,20 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+###############################################################################
+# Build image for qemu
+###############################################################################
+#FROM qemu
+# Install dependence package
+RUN apt-get install -y libglib2.0-dev libpixman-1-dev ninja-build
+# Download qemu and install
+RUN mkdir qemu && \
+ #curl -s -L "https://download.qemu.org/qemu-6.1.1.tar.xz" && \
Review Comment:
update to 7.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1281694106
> Another option is to just install the ubuntu packages for qemu. Is there a reason we need to be building it?
update to install qemu instead of building it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1280361619
add --prefix as configure part, then copy to /tools/qemu/bin, and added to env PATH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7298: install qemu on docker
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7298:
URL: https://github.com/apache/incubator-nuttx/pull/7298#discussion_r995314879
##########
tools/ci/docker/linux/Dockerfile:
##########
@@ -209,6 +218,7 @@ RUN cd renesas-tools/source/newlib && \
RUN cd /tools/renesas-tools/build/gcc && \
make && make install
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org