You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Suraj Acharya (JIRA)" <ji...@apache.org> on 2017/02/10 03:39:41 UTC

[jira] [Commented] (YETUS-315) smart-apply-patch committer mode should support signed commits

    [ https://issues.apache.org/jira/browse/YETUS-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860637#comment-15860637 ] 

Suraj Acharya commented on YETUS-315:
-------------------------------------

I tried working on this.

From my basic testing seems like this is currently working. May have been an old bug.
Correct me if i am wrong.

{code}
sacharya@sacharya-MBP:~/repos/yetus$ head 0001-Sample-test.patch
From d5fdb84a428a6ae7c757abc270b78fcae071c9e6 Mon Sep 17 00:00:00 2001
From: foo <fo...@apache.org>
Date: Thu, 9 Feb 2017 21:33:29 -0600
Subject: [PATCH] Sample test

Signed-off-by: foo<ba...@apache.org>
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sacharya@sacharya-MBP:~/repos/yetus$ ./precommit/smart-apply-patch.sh --committer 0001-Sample-test.patch
Processing: 0001-Sample-test.patch
Patch file 0001-Sample-test.patch copied to /tmp/yetus-3689.15955
Applying the patch:
Thu Feb  9 21:36:03 CST 2017
cd /Users/sacharya/repos/yetus
git am --signoff --whitespace=fix -p1 /tmp/yetus-3689.15955/patch
Applying: Sample test
sacharya@sacharya-MBP:~/repos/yetus$ git log
commit 3ac65ab775179d3ecab6e921c0077edbf6a722b8
Author: foo <fo...@apache.org>
Date:   Thu Feb 9 21:33:29 2017 -0600

    Sample test

    Signed-off-by: foo<ba...@apache.org>
    Signed-off-by: sacharya <su...@apache.org>
{code}

> smart-apply-patch committer mode should support signed commits
> --------------------------------------------------------------
>
>                 Key: YETUS-315
>                 URL: https://issues.apache.org/jira/browse/YETUS-315
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)