[jira] [Created] (PROTON-2320) Apply autofixes to resolve some flake8 code formatting issues

["Jiri Daněk (Jira)" <ji...@apache.org>]

Jiri Daněk created PROTON-2320:
----------------------------------

             Summary: Apply autofixes to resolve some flake8 code formatting issues
                 Key: PROTON-2320
                 URL: https://issues.apache.org/jira/browse/PROTON-2320
             Project: Qpid Proton
          Issue Type: Bug
          Components: python-binding
    Affects Versions: proton-c-0.33.0
            Reporter: Jiri Daněk
            Assignee: Jiri Daněk
             Fix For: proton-c-0.34.0


Python code in Proton does not follow PEP8. There are automated tools which can reformat the code to be more compliant (fix indentation, add spaces around operators, ...).

{noformat}
pip install autopep8
for f in `find -name "*.py"`; do autopep8 --in-place $f; done
{noformat}

Autopep8 has several level of "aggressiveness". The least aggressive setting only changes whitespace. At a more aggressive setting, autopep8 will also rewrite some code constructs.

My plan is to commit this in several stages. Avoid mixing manual changes and automatically generated changes in a single commit. Push the whitespace changes first and only then let autopep8 to be more creative; otherwise the rewrites get drowned in the huge initial diff.

I don't want to add flake8 to CI jobs just yet; I want to wait a few days with that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org