You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by miscer <gi...@git.apache.org> on 2015/07/30 08:35:45 UTC
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
GitHub user miscer opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30
CB-9076 Fixed StatusBarOverlaysWebView
Related issue: https://issues.apache.org/jira/browse/CB-9076
The default value can be removed since it is set in the code:
```objectivec
// src/ios/CDVStatusBar.m, line 104
_statusBarOverlaysWebView = YES; // default
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/miscer/cordova-plugin-statusbar cb-9076
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit de3f6589a757dce089ea1c4303f36c6ea3538588
Author: Michal Miškerník <mi...@miskernik.sk>
Date: 2015-07-30T06:16:08Z
CB-9076 Fixed StatusBarOverlaysWebView
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126475712
Sorry, I proposed this change because I didn't know the reason for the default preferences. I'm closing CB-9076 now.
Please @miscer, close this pull request and stay tunned to https://issues.apache.org/jira/browse/CB-9264 to check the status of the duplicate entries issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by miscer <gi...@git.apache.org>.
Github user miscer commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126207327
Yes, it does ignore the first preference, but sometimes the default value from plugin.xml is not first, but second in the code. In my case it happened when adding the iOS platform after installing the plugin:
(in config.xml)
```xml
<preference name="StatusBarOverlaysWebView" value="false" />
```
(in CLI)
```
cordova plugin add cordova-plugin-statusbar
cordova platform add ios
```
(resulting config.xml in platforms/ios)
```xml
<preference name="StatusBarOverlaysWebView" value="false" />
...
<preference name="StatusBarStyle" value="lightcontent" />
<preference name="StatusBarOverlaysWebView" value="true" />
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126413242
It happens even without adding a plugin, if you put one of the default preferences with another value, both will show (see CB-9264)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126487866
BTW, I checked what you commented about the default value not being the first one, and it isn't the first one when you add the platform, but as soon as you do a cordova prepare or cordova run it will become the first one again, so it will be ignored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126447487
Okay, then it is cordova-lib specific, or platform specific. But still it is not specific to this plugin, and this pull request does not address the issue.
The reason default values are added to config.xml is so that developers can see that they are available to be changed.
Please close this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by miscer <gi...@git.apache.org>.
Github user miscer closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126205747
Hi, I told you on the JIRA page that I could reproduce the preference being duplicated, but I couldn't reproduce your problem, in my tests it ignores the first preference if there is a second one, can you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126208513
Ok, I'll take a look, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by miscer <gi...@git.apache.org>.
Github user miscer commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126570699
Running `cordova prepare` fixes the order for me too, thanks for the tip @jcesarmobile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request: CB-9076 Fixed StatusBarOver...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/30#issuecomment-126395802
The issue is plugman specific and just happens to show up here.
Create a jira for 'Cordova plugin add ' creates duplicate config preferences.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org