[GitHub] trafodion pull request #1721: [TRAFODION-3216]UDR libraries need to be store...

[zellerh <gi...@git.apache.org>]

Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/trafodion/pull/1721#discussion_r221713729
  
    --- Diff: core/sql/common/ComMisc.cpp ---
    @@ -357,3 +358,119 @@ NABoolean ComTrafReservedColName(
     
       return FALSE;
     }
    +
    +
    +Int32  ComGenerateUdrCachedLibName(NAString libname,Int64 redeftime, NAString schemaName, NAString userid, NAString &cachedLibName, NAString &cachedLibPath)
    +{
    +  NAString libPrefix, libSuffix;
    +  struct stat statbuf;
    +  NAString redefTimeString = Int64ToNAString(redeftime);
    +  size_t lastDot = libname.last('.');
    +  if (lastDot != NA_NPOS)
    --- End diff --
    
    I wonder whether we need to do something about characters in library names that are not allowed as file names, like "/". If a user does this: create library "a/b", we would have trouble here. There are many other problematic cases as well, see https://blog.josephscott.org/2007/02/12/things-that-shouldnt-be-in-file-names-for-1000-alex/ for example. I would suggest that we replace all those invalid and maybe also valid but undesirable characters with something like an underscore or an "x". Things we should probably not allow: Control characters (below code point 32), /\|*, blanks, and any characters above 126. Or, maybe just disallow anything other than letters, digits, underscore, hash, dash and dot. Since we have the redefinition timestamp, it will still be unique.


---