You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/09/20 16:58:35 UTC
Review Request 62443: Initialized tests with Google Mock
initialization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62443/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7987
https://issues.apache.org/jira/browse/MESOS-7987
Repository: mesos
Description
-------
Switched over to explicitly using Google Mock to initialize the test
suite. This enables Google Mock option flags so that --gmock_verbose
will be supported.
Diffs
-----
src/tests/main.cpp cd30cac89c8d676d60a90f0ef843a68c241a0431
Diff: https://reviews.apache.org/r/62443/diff/1/
Testing
-------
make check (Fedora 26)
Manually verified that `--gmock_verbose=info` traces the mocked expectations.
Thanks,
James Peach
Re: Review Request 62443: Initialized tests with Google Mock
initialization.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62443/#review185802
-----------------------------------------------------------
Bad review!
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On Sept. 20, 2017, 4:58 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62443/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 4:58 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7987
> https://issues.apache.org/jira/browse/MESOS-7987
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Switched over to explicitly using Google Mock to initialize the test
> suite. This enables Google Mock option flags so that --gmock_verbose
> will be supported.
>
>
> Diffs
> -----
>
> src/tests/main.cpp cd30cac89c8d676d60a90f0ef843a68c241a0431
>
>
> Diff: https://reviews.apache.org/r/62443/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26)
>
> Manually verified that `--gmock_verbose=info` traces the mocked expectations.
>
>
> Thanks,
>
> James Peach
>
>