You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 14:46:33 UTC

[GitHub] [airflow] eladkal commented on pull request #9124: [AIRFLOW-9099] Merging multiple sql operators

eladkal commented on pull request #9124:
URL: https://github.com/apache/airflow/pull/9124#issuecomment-638896652


   My thoughts (don't take any action for the moment lets wait for thoughts of others)
   1. I'm not sure if it requires deprecation warning for BranchSqlOperator. PR https://github.com/apache/airflow/pull/8942 wasn't released yet. So the question is will it be released with this PR or not. If both PRs are released together then there is no need to maintain `airflow/operators/sql_branch_operator.py`  with deprecation warning.
   2. PrestoCheckOperator(s) were deprecated in https://github.com/apache/airflow/pull/7884 and pointing to CheckOperator(s). By merging this PR they will point to another deprecated module. Maybe worth to fix the deprecation warning for the Presto Operators as well?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org