You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "divijaksolves (via GitHub)" <gi...@apache.org> on 2026/10/16 10:55:22 UTC
[PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
divijaksolves opened a new pull request, #11810:
URL: https://github.com/apache/nifi/pull/11810
### Description
Fixes [NIFI-16454](https://issues.apache.org/jira/browse/NIFI-16454) by adding an explicit null check for `moduleName` inside `AllowListClassLoader.isModuleAllowed()`. For classes belonging to the unnamed module on the classpath, `Module.getName()` evaluates to `null`, which previously caused a `NullPointerException` during `moduleName.startsWith(...)`.
### Changes
- Updated `AllowListClassLoader.isModuleAllowed()` to package-private to enable direct unit testing, and added a null check returning `false`.
- Added `TestAllowListClassLoader` covering:
- `isModuleAllowed(null)` asserting it safely returns `false` without throwing an NPE.
- Classes from allowed Java base modules.
- Classes explicitly included in the allow-list set.
### Tracking
- Jira: https://issues.apache.org/jira/browse/NIFI-16454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "divijaksolves (via GitHub)" <gi...@apache.org>.
divijaksolves commented on PR #11810:
URL: https://github.com/apache/nifi/pull/11810#issuecomment-6216682399
> @divijaksolves you need to sign your commit
@MikeThomsen Thanks! I have signed the commit with GPG and updated the branch. Could you please approve the workflows when you have a moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #11810:
URL: https://github.com/apache/nifi/pull/11810#discussion_r4325458209
##########
nifi-stateless/nifi-stateless-bootstrap/src/main/java/org/apache/nifi/stateless/bootstrap/AllowListClassLoader.java:
##########
@@ -128,8 +128,11 @@ private boolean isClassAllowed(final String name, final Class<?> clazz) {
return false;
}
}
-
- private boolean isModuleAllowed(final String moduleName) {
+ // Package-private for testing
+ boolean isModuleAllowed(final String moduleName) {
Review Comment:
The method should be kept `private`, it does not need to be directly exposed for testing.
##########
nifi-stateless/nifi-stateless-bootstrap/src/test/java/org/apache/nifi/stateless/bootstrap/TestAllowListClassLoader.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.stateless.bootstrap;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+import java.util.Set;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+class TestAllowListClassLoader {
+
+ @Test
+ void testIsModuleAllowedNullReturnsFalse() {
+ final AllowListClassLoader classLoader = new AllowListClassLoader(
+ ClassLoader.getSystemClassLoader(),
+ Collections.emptySet()
+ );
+
+ // Before fix: moduleName.startsWith(...) threw NullPointerException
+ // After fix: returns false safely
Review Comment:
These types of comments should be removed, there is no need for historical reference to failing behavior in comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory merged PR #11810:
URL: https://github.com/apache/nifi/pull/11810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "divijaksolves (via GitHub)" <gi...@apache.org>.
divijaksolves commented on PR #11810:
URL: https://github.com/apache/nifi/pull/11810#issuecomment-6294810173
@exceptionfactory Thanks for the feedback! I have updated isModuleAllowed back to private, adjusted the unit test to verify via loadClass(), and removed the comments. The commit has been amended and pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "divijaksolves (via GitHub)" <gi...@apache.org>.
divijaksolves commented on PR #11810:
URL: https://github.com/apache/nifi/pull/11810#issuecomment-6460937196
Hi @exceptionfactory, just following up on this PR when you get a chance.
I have addressed the recommendations (reverted `isModuleAllowed` back to `private`, adjusted the unit test to verify via `loadClass()`, and cleaned up the comments).
The 3 failed checks were due to transient Maven Central download connection resets and a timeout, while the core builds and compliance checks passed. Could you please trigger a re-run of the failed workflows when convenient? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-16454: Prevent NullPointerException for unnamed modules in AllowListClassLoader [nifi]
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #11810:
URL: https://github.com/apache/nifi/pull/11810#issuecomment-6216053866
@divijaksolves you need to sign your commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org