You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/01/19 18:56:02 UTC

[GitHub] [helix] jiajunwang commented on a change in pull request #686: Add resource partition weight gauge

jiajunwang commented on a change in pull request #686: Add resource partition weight gauge
URL: https://github.com/apache/helix/pull/686#discussion_r368191477
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterStatusMonitor.java
 ##########
 @@ -519,7 +538,7 @@ public void updateRebalancerStats(String resourceName, long numPendingRecoveryRe
     }
   }
 
-  private ResourceMonitor getOrCreateResourceMonitor(String resourceName) {
+  ResourceMonitor getOrCreateResourceMonitor(String resourceName) {
 
 Review comment:
   Why?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org