[jira] Commented: (WICKET-33) Ant jar target that doesn't depend on tests

["Martijn Dashorst (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/WICKET-33?page=comments#action_12447142 ] 
            
Martijn Dashorst commented on WICKET-33:
----------------------------------------

the build should force you to run the tests from the normal flow... otherwise you won't know if the build is any good, especially from a framework perspective.

I think a number 3 might be possible (I'm a bit rusty on my ant skills tho) and that is add a condition to the ant test target:

if "maven.test.skip=true" don't run tests.

This unifies the builds between maven and ant.

WDYT?

> Ant jar target that doesn't depend on tests
> -------------------------------------------
>
>                 Key: WICKET-33
>                 URL: http://issues.apache.org/jira/browse/WICKET-33
>             Project: Wicket
>          Issue Type: Wish
>          Components: wicket
>    Affects Versions: 1.2.3
>            Reporter: Bernhard Frauendienst
>         Assigned To: Martijn Dashorst
>            Priority: Trivial
>
> I'd very much appreciate it, if the ant build file could get a jar target that doesn't depend on junit tests (those should be voluntary).
> Possible solutions:
> 1) Change "jar"-target dependency from "test" to "compile" and introduce a new "all"-target for both combined:
> 2) Keep the jar-target and create a new one that "skips" the tests (possible name: "jar-notest")
> A patch snippet for solution one is attached below:
> @@ -114,9 +114,10 @@
>                         />
>         </target>
> -       <target name="jar" depends="test" description="o Creates a JAR file for this package">
> +       <target name="jar" depends="compile" description="o Creates a JAR file for this package">
>                 <jar jarfile="${final.name}.jar"
>                         excludes="**/package.html"
>                         basedir="${build.main.classes}"/>
>         </target>
> +       <target name="all" depends="test,jar" description="o Runs the unit tests and creates a JAR file for this package"/>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira