[GitHub] [pulsar] kimcs commented on a change in pull request #4166: Allow use of pulsar-client-all shaded jar from java-module-system

[GitBox <gi...@apache.org>]

kimcs commented on a change in pull request #4166: Allow use of pulsar-client-all shaded jar from java-module-system
URL: https://github.com/apache/pulsar/pull/4166#discussion_r280699818
 
 

 ##########
 File path: pulsar-client-all/pom.xml
 ##########
 @@ -98,6 +98,7 @@
                 <includes>
                   <include>org.apache.pulsar:pulsar-client-original</include>
                   <include>org.apache.pulsar:pulsar-client-admin-original</include>
+                  <include>org.apache.pulsar:pulsar-client-api</include>
 
 Review comment:
   The reason for this inclusion is that the pulsar-client-api contains a package that is also contained in the pulsar-common module (transitive include from the other). So when pulsar-client-api is included in the shaded module, that will merge the split-package into the same jar file hence removing the split-package issue.
   
   But, it would be even better if we had a solution without using shaded jar and making it work with the java-module-system.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services