[jira] [Commented] (AIRFLOW-5595) gcs_to_bq operator - Throws error when BQ dataset isn't located in US or EU region.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16944451#comment-16944451 ] 

ASF GitHub Bot commented on AIRFLOW-5595:
-----------------------------------------

Nagalenoj commented on pull request #6258: [AIRFLOW-5595] Pass job location when initializing the operator
URL: https://github.com/apache/airflow/pull/6258
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   * As per Google docs, passing location is required to get job status except for US and EU region. Added the optional parameter for gcs_to_bq operator and handled it. 
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   * Only an optional location is passed to the underlying hook from the operator.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> gcs_to_bq operator - Throws error when BQ dataset isn't located in US or EU region.
> -----------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5595
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5595
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp, operators
>    Affects Versions: 1.10.5
>            Reporter: Lenoj
>            Assignee: Lenoj
>            Priority: Major
>
>  I have my BQ dataset in "Asia-South1" region and tried using gcs_to_bq operator. I started seeing errors after calling the operator, when the hook tries to check the status of the job. I realized there is no way to pass "location" parameter to the underlying hook from the gcs_to_bq operator, which results in no job found error when the hook tries to get the status of the job.
> As per the doc([https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/get),] the geographic location of the job is required except for US and EU.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)