You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by sh...@apache.org on 2021/04/06 05:58:27 UTC
[echarts] branch master updated: Feat(effectScatter): add clip for
effectScatter
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/master by this push:
new f72c9e2 Feat(effectScatter): add clip for effectScatter
new 27c0908 Merge pull request #14574 from susiwen8/effectScatter-clip
f72c9e2 is described below
commit f72c9e27b0ac548597b0c4de38fd96be8c10f8f7
Author: susiwen8 <su...@gmail.com>
AuthorDate: Thu Apr 1 15:28:45 2021 +0800
Feat(effectScatter): add clip for effectScatter
---
src/chart/effectScatter/EffectScatterSeries.ts | 2 ++
src/chart/effectScatter/EffectScatterView.ts | 8 +++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/chart/effectScatter/EffectScatterSeries.ts b/src/chart/effectScatter/EffectScatterSeries.ts
index f0340fb..e6f8830 100644
--- a/src/chart/effectScatter/EffectScatterSeries.ts
+++ b/src/chart/effectScatter/EffectScatterSeries.ts
@@ -71,6 +71,7 @@ export interface EffectScatterSeriesOption extends SeriesOption<EffectScatterSta
* When to show the effect
*/
showEffectOn?: 'render' | 'emphasis'
+ clip?: boolean
/**
* Ripple effect config
@@ -107,6 +108,7 @@ class EffectScatterSeriesModel extends SeriesModel<EffectScatterSeriesOption> {
// When to show the effect, option: 'render'|'emphasis'
showEffectOn: 'render',
+ clip: true,
// Ripple effect config
rippleEffect: {
diff --git a/src/chart/effectScatter/EffectScatterView.ts b/src/chart/effectScatter/EffectScatterView.ts
index 7220731..ac56824 100644
--- a/src/chart/effectScatter/EffectScatterView.ts
+++ b/src/chart/effectScatter/EffectScatterView.ts
@@ -41,10 +41,16 @@ class EffectScatterView extends ChartView {
render(seriesModel: EffectScatterSeriesModel, ecModel: GlobalModel, api: ExtensionAPI) {
const data = seriesModel.getData();
const effectSymbolDraw = this._symbolDraw;
- effectSymbolDraw.updateData(data);
+ effectSymbolDraw.updateData(data, {clipShape: this._getClipShape(seriesModel)});
this.group.add(effectSymbolDraw.group);
}
+ _getClipShape(seriesModel: EffectScatterSeriesModel) {
+ const coordSys = seriesModel.coordinateSystem;
+ const clipArea = coordSys && coordSys.getArea && coordSys.getArea();
+ return seriesModel.get('clip', true) ? clipArea : null;
+ }
+
updateTransform(seriesModel: EffectScatterSeriesModel, ecModel: GlobalModel, api: ExtensionAPI) {
const data = seriesModel.getData();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org