You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ajs6f <gi...@git.apache.org> on 2015/06/09 19:48:46 UTC
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/76
Eliminate <jena-core>/jena.cmdline, deprecate rdfcat
https://issues.apache.org/jira/browse/JENA-962
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-962
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 86c0ca73d37cc68b8acb1c23c649c125a84540fc
Author: ajs6f <aj...@virginia.edu>
Date: 2015-06-09T17:48:01Z
Eliminate <jena-core>/jena.cmdline, deprecate rdfcat
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32212133
--- Diff: jena-core/pom.xml ---
@@ -56,12 +56,24 @@
<groupId>xerces</groupId>
<artifactId>xercesImpl</artifactId>
</dependency>
+
+ <dependency>
+ <artifactId>commons-cli</artifactId>
+ <groupId>commons-cli</groupId>
+ <version>1.3</version>
+ </dependency>
--- End diff --
Can we have dependency version management in jena-parent please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32220786
--- Diff: jena-core/pom.xml ---
@@ -56,12 +56,24 @@
<groupId>xerces</groupId>
<artifactId>xercesImpl</artifactId>
</dependency>
+
+ <dependency>
+ <artifactId>commons-cli</artifactId>
+ <groupId>commons-cli</groupId>
+ <version>1.3</version>
+ </dependency>
--- End diff --
Yep, I'll take care of that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/76#issuecomment-111221573
Thanks for clearing it up. I've just pulled it into the codebase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32220648
--- Diff: jena-core/src/main/java/jena/RuleMap.java ---
@@ -50,7 +53,7 @@
* </p>
*/
public class RuleMap {
- static { setLog4jConfiguration() ; }
+ static { setCmdLogging("jena-log4j.properties") ; }
--- End diff --
Sure, I'll make that change.I'm still getting my head (slowly) around the logging facilities.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32212217
--- Diff: jena-core/src/test/java/org/apache/jena/test/TestPackage.java ---
@@ -32,7 +33,7 @@
public class TestPackage extends TestCase {
--- End diff --
`Test_rdfcat` now has a lot of deprecation warnings. Is it just a case of `@SuppressWarnings("deprecation")` on the class or is there something else going on?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32211834
--- Diff: jena-core/src/main/java/jena/RuleMap.java ---
@@ -50,7 +53,7 @@
* </p>
*/
public class RuleMap {
- static { setLog4jConfiguration() ; }
+ static { setCmdLogging("jena-log4j.properties") ; }
--- End diff --
Can this be plain `setCmdLogging()` which (1) is sensitive to a local log4j.properties if the user that and (2) has a built-in config in case no properties file is found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Eliminate /jena.cmdline, deprecate r...
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/76#discussion_r32220860
--- Diff: jena-core/src/test/java/org/apache/jena/test/TestPackage.java ---
@@ -32,7 +33,7 @@
public class TestPackage extends TestCase {
--- End diff --
It's because I `@Deprecate`d `rdfcat`. I'll suppress those warnings, since they convey no real information.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---