You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/04/19 00:48:49 UTC

[kudu-CR] docs: Add breakpad documentation to user guide

Mike Percy has posted comments on this change.

Change subject: docs: Add breakpad documentation to user guide
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6504/1/docs/minidumps.adoc
File docs/minidumps.adoc:

PS1, Line 34: To disable minidump generation, set the
            : `--enable_minidumps` flag to `false`. 
> why would a user want to disable it?
I suppose they might want to disable it if they are very paranoid about PII that might be on the stack at the time of a crash. But I'll just remove this; they can refer to the configuration reference to find the flag to disable it.


Line 64: Kudu developers have access to the minidump tools in their development
> I think this developer-facing doc should be moved to different docs folder 
Removed for now.


Line 100: == Dumping the minidump stack trace to a text file (TODO)
> TODO?
Removed


http://gerrit.cloudera.org:8080/#/c/6504/1/docs/support/jekyll-templates/document.html.erb
File docs/support/jekyll-templates/document.html.erb:

Line 101:         :minidumps, "Debugging with minidumps",
> maybe this belongs under Troubleshooting?
Moved to troubleshooting and changed the title of the section to Reporting Kudu Crashes.


-- 
To view, visit http://gerrit.cloudera.org:8080/6504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes