You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/16 20:54:15 UTC
[GitHub] [lucene] mayya-sharipova opened a new pull request #214: LUCENE-10027 provide leaf sorter from commit
mayya-sharipova opened a new pull request #214:
URL: https://github.com/apache/lucene/pull/214
Provide leaf sorter for directory readers opened from IndexCommit
LUCENE-9507 allowed to provide a leaf sorter for directory readers.
One API that was missed is to allow to provide a leaf sorter
for directory readers opened from an index commit.
This patch address this.
Relates to PR#32.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova merged pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #214:
URL: https://github.com/apache/lucene/pull/214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
dnhatn commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r672315261
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
I think we also need to add another method that supports both `leafSorter` and `minSupportedMajorVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
dnhatn commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r672315261
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
I think we also need to add another method that supports both `leafSorter` and `minSupportedMajorVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r678516508
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
Actually after reading `CHANGES.txt` file, I've noticed many API changes even in minor versions. So, @jpountz the commit a44c8120133aa01588c76b58321b8bffae0dd0c7 addresses your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r678507441
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
@dnhatn @jpountz Thanks for your comments.
@jpountz About this comment:
> Since both minSupportedMajorVersion and leafSorter are super expert parameters, I think it's fine to require that users to provide both instead of keeping adding new variants of DirectoryReader#open.
I am not happy either about adding new variant of `DirectoryReader#open`, but are we ok to modify the current public API: `DirectoryReader open(IndexCommit, minSupportedMajorVersion)` to add a new parameter? The modification will be in the minor 8.10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
jpountz commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r673086767
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
Since both `minSupportedMajorVersion` and `leafSorter` are super expert parameters, I think it's fine to require that users to provide both instead of keeping adding new variants of `DirectoryReader#open`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dnhatn commented on a change in pull request #214: LUCENE-10027 provide leaf sorter from commit
Posted by GitBox <gi...@apache.org>.
dnhatn commented on a change in pull request #214:
URL: https://github.com/apache/lucene/pull/214#discussion_r672315261
##########
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##########
@@ -122,6 +122,23 @@ public static DirectoryReader open(final IndexCommit commit) throws IOException
return StandardDirectoryReader.open(commit.getDirectory(), commit, null);
}
+ /**
+ * Expert: returns an IndexReader reading the index in the given {@link IndexCommit}.
+ *
+ * @param commit the commit point to open
+ * @param leafSorter a comparator for sorting leaf readers. Providing leafSorter is useful for
+ * indices on which it is expected to run many queries with particular sort criteria (e.g. for
+ * time-based indices, this is usually a descending sort on timestamp). In this case {@code
+ * leafSorter} should sort leaves according to this sort criteria. Providing leafSorter allows
+ * to speed up this particular type of sort queries by early terminating while iterating
+ * through segments and segments' documents
+ * @throws IOException if there is a low-level IO error
+ */
+ public static DirectoryReader open(final IndexCommit commit, Comparator<LeafReader> leafSorter)
Review comment:
I think we also need to add another method that supports both `leafSorter` and `minSupportedMajorVersion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org