You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/02/21 23:31:17 UTC
[GitHub] [trafficcontrol] rob05c opened a new pull request #5552: Add TO client v4 fallback
rob05c opened a new pull request #5552:
URL: https://github.com/apache/trafficcontrol/pull/5552
Also moves duplicate fallback and other duplicate client code
to a shared lib.
No new tests, existing TO API Tests cover these changes.
No docs, no interface change.
No changelog, client fallback already has a changelog entry.
- [x] This PR fixes #5518 OR is not related to any Issue
## Which Traffic Control components are affected by this PR?
- Traffic Control Client Go
## What is the best way to verify this PR?
Run tests. Make requests with the client, verify they work as expected.
## If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix.
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #5552: Add TO client v4 fallback
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #5552:
URL: https://github.com/apache/trafficcontrol/pull/5552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5552: Add TO client v4 fallback
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5552:
URL: https://github.com/apache/trafficcontrol/pull/5552#issuecomment-802915349
I don't believe this can go into 5.1.1 unless we're putting APIv4 into that release. Which I don't want to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rob05c commented on pull request #5552: Add TO client v4 fallback
Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #5552:
URL: https://github.com/apache/trafficcontrol/pull/5552#issuecomment-783587838
Fixed the Enroller
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #5552: Add TO client v4 fallback
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on pull request #5552:
URL: https://github.com/apache/trafficcontrol/pull/5552#issuecomment-783491829
Looks like it failed to build the enroller:
```
2021-02-22T00:34:57.7359211Z #6 45.14 Running scriptlet: gettext-0.19.8.1-17.el8.x86_64 19/21#17 8.163 github.com/apache/trafficcontrol/traffic_ops/v4-client imports
2021-02-22T00:34:57.7360512Z #17 8.163 github.com/apache/trafficcontrol/traffic_ops/toclientlib: no matching versions for query "latest"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org