You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@lyra.org> on 2001/12/22 00:18:57 UTC

Re: svn commit: rev 712 - trunk/tools

That is all well and humorous, but now it instills a total lack of
confidence on the part of the user.

WHAT are you trying to really say? Without the gimmicky stuff? Should the
user save a log or NOT?

Given that the script logs all changes, I would presume that it doesn't need
to save a log. And that this note should say that all changes are backed up,
so the user doesn't need to save a copy.

Funny sarcasm is good... but in a real tool, it can cause much more
consternation than laughs :-(

Cheers,
-g

On Fri, Dec 21, 2001 at 12:58:08PM -0600, kfogel@tigris.org wrote:
> Author: kfogel
> Date: 2001-12-21 18:58 GMT
> New Revision: 712
> 
> Modified:
>    trunk/tools/tweak-log.cgi
> Log:
> * tools/tweak-log.cgi (doFetchLog): Display prominent notice about how
> there's no need to save the output of `svn log' first because nothing
> could possibly go wrong.  Right?
> 
> 
> Modified: trunk/tools/tweak-log.cgi
> ==============================================================================
> --- OLD/trunk/tools/tweak-log.cgi	Fri Dec 21 12:58:08 2001
> +++ NEW/trunk/tools/tweak-log.cgi	Fri Dec 21 12:58:08 2001
> @@ -175,6 +175,14 @@
>      print "<h1>Editing Log Message for Revision $rev</h1>\n";
>      print "<h2>Current log message:</h2>\n";
>      print "<blockquote><hr /><pre>$escaped_log</pre><hr /></blockquote>\n";
> +    print "\n<p>\n";
> +    print "<font color=\"red\">\n";
> +    print "<i>This cgi script is perfect and has no bugs.  Therefore, the\n";
> +    print "ordinarily sensible precaution of running `<tt>svn log</tt>' and\n";
> +    print "saving the output before you modify a log message is entirely\n";
> +    print "unnecessary.  After all, what could possibly go wrong?</i>\n";
> +    print "</font>\n";
> +    print "\n<p>\n";
>      print "<form action=\"$gActionURL\" method=\"post\">\n";
>      print "<h2>New log message:</h2>\n";
>      print "<blockquote>\n";
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 712 - trunk/tools

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Greg Stein <gs...@lyra.org> writes:
> That is all well and humorous, but now it instills a total lack of
> confidence on the part of the user.
> 
> WHAT are you trying to really say? Without the gimmicky stuff? Should the
> user save a log or NOT?
> 
> Given that the script logs all changes, I would presume that it doesn't need
> to save a log. And that this note should say that all changes are backed up,
> so the user doesn't need to save a copy.
> 
> Funny sarcasm is good... but in a real tool, it can cause much more
> consternation than laughs :-(

Mmm, good point.  I wasn't thinking of this as a real tool, but it
surely is; come back in a year and it'll have thousands of users and
its own bug database, no doubt. :-)

I've made your suggested change to the message, thanks!

-Karl

> On Fri, Dec 21, 2001 at 12:58:08PM -0600, kfogel@tigris.org wrote:
> > Author: kfogel
> > Date: 2001-12-21 18:58 GMT
> > New Revision: 712
> > 
> > Modified:
> >    trunk/tools/tweak-log.cgi
> > Log:
> > * tools/tweak-log.cgi (doFetchLog): Display prominent notice about how
> > there's no need to save the output of `svn log' first because nothing
> > could possibly go wrong.  Right?
> > 
> > 
> > Modified: trunk/tools/tweak-log.cgi
> > ==============================================================================
> > --- OLD/trunk/tools/tweak-log.cgi	Fri Dec 21 12:58:08 2001
> > +++ NEW/trunk/tools/tweak-log.cgi	Fri Dec 21 12:58:08 2001
> > @@ -175,6 +175,14 @@
> >      print "<h1>Editing Log Message for Revision $rev</h1>\n";
> >      print "<h2>Current log message:</h2>\n";
> >      print "<blockquote><hr /><pre>$escaped_log</pre><hr /></blockquote>\n";
> > +    print "\n<p>\n";
> > +    print "<font color=\"red\">\n";
> > +    print "<i>This cgi script is perfect and has no bugs.  Therefore, the\n";
> > +    print "ordinarily sensible precaution of running `<tt>svn log</tt>' and\n";
> > +    print "saving the output before you modify a log message is entirely\n";
> > +    print "unnecessary.  After all, what could possibly go wrong?</i>\n";
> > +    print "</font>\n";
> > +    print "\n<p>\n";
> >      print "<form action=\"$gActionURL\" method=\"post\">\n";
> >      print "<h2>New log message:</h2>\n";
> >      print "<blockquote>\n";
> > 
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: svn-help@subversion.tigris.org
> 
> -- 
> Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org