You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/02 08:01:22 UTC
[GitHub] [flink] aljoscha opened a new pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
aljoscha opened a new pull request #13531:
URL: https://github.com/apache/flink/pull/13531
## What is the purpose of the change
This is part of FLIP-134 (https://cwiki.apache.org/confluence/x/4i94CQ).
## Verifying this change
This is not adding anything, only deprecating methods. You can verify the deprecation message.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
* 12b57911b704cce325f3c6e8c31e5744e284f3db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703523727
I pushed a commit that removes all mentions of `timeWindow*()` from the documentation. In some places I replace it by a processing-time assigner because it wouldn't work with event time. All other cases now use an explicit event-time assigner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703598381
Yes, you're right, I missed the `README.md`. Other than that, I tried to use `TumblingProcessingTimeWindows` when it's clear in the example that no event-time source is used. If the example is vague on the source, like the examples in `windows.md`, `experimental.md`, and `parallel.md` then I used `TumblingEventTimeWindows`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
}, {
"hash" : "4609bf890fe953a697b15f26280729abc36ea913",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204",
"triggerID" : "4609bf890fe953a697b15f26280729abc36ea913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4609bf890fe953a697b15f26280729abc36ea913 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703486706
@aljoscha from my side there is only the comment that @dawidwys made about the docs. After this is resolved and Azure gives green, feel free to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
}, {
"hash" : "4609bf890fe953a697b15f26280729abc36ea913",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204",
"triggerID" : "4609bf890fe953a697b15f26280729abc36ea913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 12b57911b704cce325f3c6e8c31e5744e284f3db Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200)
* 09c97e5bdf9e3ea5719d772749b9bb542ec89514 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202)
* 4609bf890fe953a697b15f26280729abc36ea913 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703478881
Do we have a plan for removing the deprecated methods from docs? There are quite some.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
* 12b57911b704cce325f3c6e8c31e5744e284f3db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200)
* 09c97e5bdf9e3ea5719d772749b9bb542ec89514 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
}, {
"hash" : "4609bf890fe953a697b15f26280729abc36ea913",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204",
"triggerID" : "4609bf890fe953a697b15f26280729abc36ea913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 09c97e5bdf9e3ea5719d772749b9bb542ec89514 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202)
* 4609bf890fe953a697b15f26280729abc36ea913 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7204)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #13531:
URL: https://github.com/apache/flink/pull/13531#discussion_r499415647
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -615,7 +615,12 @@ public IntervalJoined(
* {@link org.apache.flink.streaming.api.environment.StreamExecutionEnvironment#setStreamTimeCharacteristic(org.apache.flink.streaming.api.TimeCharacteristic)}
*
* @param size The size of the window.
+ *
+ * @deprecated Please use {@link #windowAll(WindowAssigner)} with either {@link
+ * TumblingEventTimeWindows} or {@link TumblingProcessingTimeWindows}. For more information,
Review comment:
I think that was copied from the `timeWindowAll` :P
The deprecation message should mention `window()`, not `windowAll()`.
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
##########
@@ -633,7 +638,12 @@ public IntervalJoined(
* {@link org.apache.flink.streaming.api.environment.StreamExecutionEnvironment#setStreamTimeCharacteristic(org.apache.flink.streaming.api.TimeCharacteristic)}
*
* @param size The size of the window.
+ *
+ * @deprecated Please use {@link #windowAll(WindowAssigner)} with either {@link
+ * SlidingEventTimeWindows} or {@link SlidingProcessingTimeWindows}. For more information,
+ * see the deprecation notice on {@link TimeCharacteristic}
*/
+ @Deprecated
Review comment:
Same as above.
##########
File path: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/KeyedStream.scala
##########
@@ -231,11 +231,36 @@ class KeyedStream[T, K](javaStream: KeyedJavaStream[T, K]) extends DataStream[T]
* [[StreamExecutionEnvironment.setStreamTimeCharacteristic()]]
*
* @param size The size of the window.
+ *
+ * @deprecated Please use [[windowAll()]] with either [[TumblingEventTimeWindows]] or
+ * [[TumblingProcessingTimeWindows]]. For more information, see the deprecation
+ * notice on [[org.apache.flink.streaming.api.TimeCharacteristic]].
*/
+ @deprecated
Review comment:
Same as in the java classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
* 12b57911b704cce325f3c6e8c31e5744e284f3db UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha closed pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha closed pull request #13531:
URL: https://github.com/apache/flink/pull/13531
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on a change in pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #13531:
URL: https://github.com/apache/flink/pull/13531#discussion_r499506498
##########
File path: docs/dev/stream/experimental.md
##########
@@ -60,7 +60,7 @@ Code example:
StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
DataStreamSource<Integer> source = ...
DataStreamUtils.reinterpretAsKeyedStream(source, (in) -> in, TypeInformation.of(Integer.class))
- .timeWindow(Time.seconds(1))
+ .window(TumblingEventTimeWindows.of(Time.seconds(1)))
Review comment:
Same as above in both.
##########
File path: docs/dev/parallel.md
##########
@@ -55,7 +55,7 @@ DataStream<String> text = [...]
DataStream<Tuple2<String, Integer>> wordCounts = text
.flatMap(new LineSplitter())
.keyBy(value -> value.f0)
- .timeWindow(Time.seconds(5))
+ .window(TumblingEventTimeWindows.of(Time.seconds(5)))
.sum(1).setParallelism(5);
Review comment:
For all of these changes, same as above about event vs processing time.
##########
File path: docs/dev/stream/operators/windows.md
##########
@@ -684,7 +684,7 @@ DataStream<Tuple2<String, Long>> input = ...;
input
.keyBy(t -> t.f0)
- .timeWindow(Time.minutes(5))
+ .window(TumblingEventTimeWindows.of(Time.minutes(5)))
Review comment:
Same as above.
##########
File path: README.md
##########
@@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n')
val windowCounts = text.flatMap { w => w.split("\\s") }
.map { w => WordWithCount(w, 1) }
.keyBy("word")
- .timeWindow(Time.seconds(5))
+ .window(TumblingEventTimeWindow.of(Time.seconds(5)))
Review comment:
I think here it will not work without a `WatermarkStrategy`, right? If this is correct, we should maybe put processing time window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sjwiesman commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
sjwiesman commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702842247
@aljoscha since we're making this change, what do you think about deprecating `org.apache.flink.streaming.api.windowing.time.Time` in favor of `org.apache.flink.api.common.time.Time`? and adding that as an accepted type on the window assigners?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703698276
They will if the source provides watermarks, which the new FLIP-27 sources will do. But yes, they won't work out of box, but the examples also don't define any sources so they also don't work out-of-the-box to begin with. 😅
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
* 12b57911b704cce325f3c6e8c31e5744e284f3db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200)
* 09c97e5bdf9e3ea5719d772749b9bb542ec89514 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703484840
Addressed comments, PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702591517
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162",
"triggerID" : "2662522fc5199438ca7bd7e8a5d1825d2aa80f14",
"triggerType" : "PUSH"
}, {
"hash" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200",
"triggerID" : "12b57911b704cce325f3c6e8c31e5744e284f3db",
"triggerType" : "PUSH"
}, {
"hash" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202",
"triggerID" : "09c97e5bdf9e3ea5719d772749b9bb542ec89514",
"triggerType" : "PUSH"
}, {
"hash" : "4609bf890fe953a697b15f26280729abc36ea913",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4609bf890fe953a697b15f26280729abc36ea913",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7162)
* 12b57911b704cce325f3c6e8c31e5744e284f3db Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7200)
* 09c97e5bdf9e3ea5719d772749b9bb542ec89514 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7202)
* 4609bf890fe953a697b15f26280729abc36ea913 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703480530
@sjwiesman : https://issues.apache.org/jira/browse/FLINK-14068
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
aljoscha commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703447514
@sjwiesman Should we even roll our own class in the future or use one of the "new" builtin classes like `Duration`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
dawidwys commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703471242
I think there was a discussion on that topic before (maybe even a vote) and the consensus was that we want to switch over to the `java.time` classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] kl0u commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-703613996
Ok but this way the examples do not work "out-of-the-box", right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13531: [FLINK-19318] Deprecate timeWindow() operations in DataStream API
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13531:
URL: https://github.com/apache/flink/pull/13531#issuecomment-702588113
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2662522fc5199438ca7bd7e8a5d1825d2aa80f14 (Fri Oct 02 08:04:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org