You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "lzx404243 (via GitHub)" <gi...@apache.org> on 2023/07/28 15:35:05 UTC
[GitHub] [trafficserver] lzx404243 opened a new pull request, #10111: Deprecate cqtx log field
lzx404243 opened a new pull request, #10111:
URL: https://github.com/apache/trafficserver/pull/10111
This fixes #10066
Currently a draft to test the docs via CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #10111: Deprecate cqtx log field
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111#issuecomment-1665808919
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] lzx404243 commented on a diff in pull request #10111: Deprecate cqtx log field
Posted by "lzx404243 (via GitHub)" <gi...@apache.org>.
lzx404243 commented on code in PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111#discussion_r1283479431
##########
doc/admin-guide/logging/formatting.en.rst:
##########
@@ -584,19 +584,18 @@ sshv Origin Response Origin server's response HTTP version.
Request Details
~~~~~~~~~~~~~~~
-.. _cqtx:
-
-The following logging fields are used to obtain the actual HTTP request
-details.
+The following logging fields show the details of the actual HTTP request and can be used in combination to reproduce a HTTP/1.1 request line (e.g. ``GET http://www.company.com HTTP/1.0``).
Review Comment:
Good point. Updated that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on a diff in pull request #10111: Deprecate cqtx log field
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111#discussion_r1280886005
##########
doc/admin-guide/logging/formatting.en.rst:
##########
@@ -584,19 +584,18 @@ sshv Origin Response Origin server's response HTTP version.
Request Details
~~~~~~~~~~~~~~~
-.. _cqtx:
-
-The following logging fields are used to obtain the actual HTTP request
-details.
+The following logging fields show the details of the actual HTTP request and can be used in combination to reproduce a HTTP/1.1 request line (e.g. ``GET http://www.company.com HTTP/1.0``).
Review Comment:
maybe generalize to say "... reproduce a client request line" instead of HTTP/1.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] serrislew commented on a diff in pull request #10111: Deprecate cqtx log field
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew commented on code in PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111#discussion_r1280887213
##########
doc/release-notes/upgrading.en.rst:
##########
@@ -85,3 +85,8 @@ Metrics
------------------
The HTTP connection metric proxy.process.http.dead_server.no_requests has been renamed to proxy.process.http.down_server.no_requests.
+
+Logging
+------------------
+
+The ``cqtx`` log field has been deprecated.
Review Comment:
"deprecated but can still be replaced by ``cqhm pqu cqpv``"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #10111: Remove cqtx log field
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] lzx404243 commented on a diff in pull request #10111: Deprecate cqtx log field
Posted by "lzx404243 (via GitHub)" <gi...@apache.org>.
lzx404243 commented on code in PR #10111:
URL: https://github.com/apache/trafficserver/pull/10111#discussion_r1283479938
##########
doc/release-notes/upgrading.en.rst:
##########
@@ -85,3 +85,8 @@ Metrics
------------------
The HTTP connection metric proxy.process.http.dead_server.no_requests has been renamed to proxy.process.http.down_server.no_requests.
+
+Logging
+------------------
+
+The ``cqtx`` log field has been deprecated.
Review Comment:
Yeah it's good to mention the replacement options. Added that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org