Re: [PR] Remove legacy ZooKeeper backpressure cluster state methods and config (#8994) (storm)

["reiabreu (via GitHub)" <gi...@apache.org>]

reiabreu commented on code in PR #9168:
URL: https://github.com/apache/storm/pull/9168#discussion_r4303177193


##########
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java:
##########
@@ -1138,7 +1138,6 @@ public static Set<String> topoIdsToClean(IStormClusterState state, BlobStore sto
         cleanable.addAll(Utils.OR(state.heartbeatStorms(), EMPTY_STRING_LIST));
         cleanable.addAll(Utils.OR(state.errorTopologies(), EMPTY_STRING_LIST));
         cleanable.addAll(Utils.OR(store.storedTopoIds(), EMPTY_STRING_SET));
-        cleanable.addAll(Utils.OR(state.backpressureTopologies(), EMPTY_STRING_LIST));

Review Comment:
   With this line gone, `/backpressure` znodes left by older versions, or by topologies that set `topology.backpressure.enable`, are never cleaned up. An upgrade note would help.



##########
storm-client/src/jvm/org/apache/storm/Config.java:
##########
@@ -131,13 +131,6 @@ public class Config extends HashMap<String, Object> {
     @IsInteger
     @IsPositiveNumber
     public static final String TASK_CREDENTIALS_POLL_SECS = "task.credentials.poll.secs";
-    /**
-     * Whether to enable backpressure in for a certain topology.
-     * Note: Retained for enabling transition from 1.x. Will be removed soon.
-     */
-    @Deprecated(forRemoval = true, since = "2.0.0")
-    @IsBoolean
-    public static final String TOPOLOGY_BACKPRESSURE_ENABLE = "topology.backpressure.enable";

Review Comment:
   This removes a public constant. The umbrella issue (#8994) asks for release notes and upgrade-guide entries for removals, and this PR doesn't add one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org