You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "RHSaliya (via GitHub)" <gi...@apache.org> on 2023/04/06 03:47:11 UTC
[GitHub] [commons-csv] RHSaliya opened a new pull request, #319: refactor: made some minor refactorings.
RHSaliya opened a new pull request, #319:
URL: https://github.com/apache/commons-csv/pull/319
I'm learning how to contribute to open-source projects. This is my first pull request. So, I have not made major changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] RHSaliya commented on pull request #319: refactor: made some minor refactorings.
Posted by "RHSaliya (via GitHub)" <gi...@apache.org>.
RHSaliya commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1499143335
Sorry, I will make more changes and make a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory closed pull request #319: refactor: made some minor refactorings.
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #319: refactor: made some minor refactorings.
URL: https://github.com/apache/commons-csv/pull/319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #319: refactor: made some minor refactorings.
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1598590616
Closing: no reply.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #319: refactor: made some minor refactorings.
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1499083892
This looks like a change for change's sake, without explanation, so -1 from me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] garydgregory commented on pull request #319: refactor: made some minor refactorings.
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1592805679
Hi @RHSaliya
-1: sorry but this looks like changes for changes sake.
You can look at Jira for bug reports and feature requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-csv] codecov-commenter commented on pull request #319: refactor: made some minor refactorings.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #319:
URL: https://github.com/apache/commons-csv/pull/319#issuecomment-1498594804
## [Codecov](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#319](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f20f4a) into [master](https://codecov.io/gh/apache/commons-csv/commit/1842b788fd6bbcbc569b07b9f8a81a2d60c49f87?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1842b78) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #319 +/- ##
=========================================
Coverage 97.87% 97.87%
Complexity 549 549
=========================================
Files 11 11
Lines 1178 1178
Branches 204 204
=========================================
Hits 1153 1153
Misses 13 13
Partials 12 12
```
| [Impacted Files](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rc/main/java/org/apache/commons/csv/CSVFormat.java](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVkZvcm1hdC5qYXZh) | `98.02% <100.00%> (ø)` | |
| [...c/main/java/org/apache/commons/csv/CSVPrinter.java](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NTVlByaW50ZXIuamF2YQ==) | `95.78% <100.00%> (ø)` | |
| [...rc/main/java/org/apache/commons/csv/Constants.java](https://codecov.io/gh/apache/commons-csv/pull/319?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY3N2L0NvbnN0YW50cy5qYXZh) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org