You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org> on 2019/08/15 21:36:31 UTC

[Impala-ASF-CR] IMPALA-8124: TestWebPage::test catalog should run serially.

Anurag Mantripragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14075


Change subject: IMPALA-8124: TestWebPage::test_catalog should run serially.
......................................................................

IMPALA-8124: TestWebPage::test_catalog should run serially.

This test scrapes the /catalog webpage for metrics. This can
occasionally run into a race condition when a table lock is
being held and the test tries to get the metrics. This result in
a failed assert for the metrics.

Also, seperated out an assert with AND into two different asserts
so it's easy to track which one failed.

Testing:
Ran multiple runs of this test locally while refreshing the table.

Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
---
M tests/webserver/test_web_pages.py
1 file changed, 5 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/14075/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.

Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 18:35:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 23:19:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4810/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 18:35:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................

IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.

This test scrapes the /catalog webpage for metrics. This can
occasionally run into a race condition when a table lock is
being held for functional*.* tables and the test tries to get
the metrics. This result in a failed assert for the metrics.
This change rewrites the test to create new tables with
unique_database fixture to avoid flakiness.

Also, seperated out an assert with AND into two different asserts
so it's easy to track which one failed.

Testing:
Ran multiple runs of this test locally while refreshing the table.

Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Reviewed-on: http://gerrit.cloudera.org:8080/14075
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
1 file changed, 41 insertions(+), 14 deletions(-)

Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 3
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8124: TestWebPage::test catalog should run serially.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: TestWebPage::test_catalog should run serially.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4273/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 22:19:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.

Anurag Mantripragada has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................

IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.

Also, seperated out an assert with AND into two different asserts
so it's easy to track which one failed.

Testing:
Ran multiple runs of this test locally while refreshing the table.

Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
---
M tests/webserver/test_web_pages.py
1 file changed, 41 insertions(+), 14 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/14075/2
--
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-8124: TestWebPage::test catalog should run serially.

Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.

Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: TestWebPage::test_catalog should run serially.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14075/1/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

http://gerrit.cloudera.org:8080/#/c/14075/1/tests/webserver/test_web_pages.py@274
PS1, Line 274:   @pytest.mark.execute_serially
How about using unique db fixture rather than running serially?



-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 1
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Aug 2019 21:43:19 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8124: Modify TestWebPage::test catalog to avoid flakiness.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14075 )

Change subject: IMPALA-8124: Modify TestWebPage::test_catalog to avoid flakiness.
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4284/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I341bf25baf8d9316a21a9eff860de84b33afd12f
Gerrit-Change-Number: 14075
Gerrit-PatchSet: 2
Gerrit-Owner: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Aug 2019 19:32:30 +0000
Gerrit-HasComments: No