[PR] THRIFT-6045: Limit struct read/write recursion depth in Ruby library [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G opened a new pull request, #3550:
URL: https://github.com/apache/thrift/pull/3550

   ## Summary
   
   - Adds `increment_recursion_depth` / `decrement_recursion_depth` methods to `BaseProtocol`
   - Limit is 64; raises `ProtocolException::DEPTH_LIMIT` when exceeded
   - `Struct` module's `read` / `write` methods wrap the body with `begin/ensure` to guarantee the counter is always restored
   
   ## Test plan
   
   - [ ] Unit tests for depth allow/reject/restore via `ruby -Ilib test/unit/...`
   - [ ] Cross-language tests unaffected
   
   🤖 Generated with [Claude Code](https://claude.ai/claude-code)
   
   Co-Authored-By: Claude Sonnet 4.6 <no...@anthropic.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-6045: Limit struct read/write recursion depth in Ruby library [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G commented on PR #3550:
URL: https://github.com/apache/thrift/pull/3550#issuecomment-4584982948

   > This PR is insufficient:
   
   It is way more than that. That#s hy I made it a draft. Different story.
   
   >  I can extract my change to merge it ahead of the configuration class
   
   Ok i close this then and leave it up to you, including the ticker.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] THRIFT-6045: Add recursion-depth round-trip test for the Ruby library [thrift]

["Jens-G (via GitHub)" <gi...@apache.org>]

Jens-G merged PR #3550:
URL: https://github.com/apache/thrift/pull/3550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org