You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Yi Tang (Jira)" <ji...@apache.org> on 2021/03/23 06:27:00 UTC

[jira] [Updated] (FLINK-21921) Drop ADDED event in callback handler in KubernetesLeaderRetrievalDriver

     [ https://issues.apache.org/jira/browse/FLINK-21921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yi Tang updated FLINK-21921:
----------------------------
    Description: 
The comment is not exactly accurate in case of JM restarting or ConfigMap restarting(KubernetesTooOldResourceVersionException)

{code:java}
private class ConfigMapCallbackHandlerImpl
            implements FlinkKubeClient.WatchCallbackHandler<KubernetesConfigMap> {

        @Override
        public void onAdded(List<KubernetesConfigMap> configMaps) {
            // The ConfigMap is created by KubernetesLeaderElectionDriver with empty data. We do not
            // process this
            // useless event.
        }
{code}

We may should handle it like onModified.

  was:
The comment is not exactly accurate in case of JM restarting or ConfigMap restarting(KubernetesTooOldResourceVersionException)

{code:java}
private class ConfigMapCallbackHandlerImpl
            implements FlinkKubeClient.WatchCallbackHandler<KubernetesConfigMap> {

        @Override
        public void onAdded(List<KubernetesConfigMap> configMaps) {
            // The ConfigMap is created by KubernetesLeaderElectionDriver with empty data. We do not
            // process this
            // useless event.
        }
{code}


> Drop ADDED event in callback handler in KubernetesLeaderRetrievalDriver
> -----------------------------------------------------------------------
>
>                 Key: FLINK-21921
>                 URL: https://issues.apache.org/jira/browse/FLINK-21921
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Yi Tang
>            Priority: Major
>
> The comment is not exactly accurate in case of JM restarting or ConfigMap restarting(KubernetesTooOldResourceVersionException)
> {code:java}
> private class ConfigMapCallbackHandlerImpl
>             implements FlinkKubeClient.WatchCallbackHandler<KubernetesConfigMap> {
>         @Override
>         public void onAdded(List<KubernetesConfigMap> configMaps) {
>             // The ConfigMap is created by KubernetesLeaderElectionDriver with empty data. We do not
>             // process this
>             // useless event.
>         }
> {code}
> We may should handle it like onModified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)