You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/05/21 00:47:43 UTC
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19908
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Revert "IMPALA-11253: Support testing with Java 11"
This reverts commit ee6395db760e6629442c7e3fdda34519c61641c5 as it is
not flexible enough at detecting Java automatically in likely build
environments.
Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
---
M CMakeLists.txt
M LICENSE.txt
M bin/bootstrap_system.sh
D bin/impala-config-java.sh
M bin/impala-config.sh
M bin/run-all-tests.sh
A cmake_modules/FindJNI.cmake
M fe/pom.xml
M fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java
M java/TableFlattener/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
M testdata/bin/run-mini-dfs.sh
M testdata/bin/run-ranger-server.sh
D tests/verifiers/test_banned_log_messages.py
24 files changed, 406 insertions(+), 217 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/19908/1
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@243
PS1, Line 243: "https://launchpadlibrarian.net/380913637/openjdk-8-jdk_8u181-b13-0ubuntu0.16.04.1_amd64.deb" \
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@244
PS1, Line 244: "https://launchpadlibrarian.net/380913636/openjdk-8-jdk-headless_8u181-b13-0ubuntu0.16.04.1_amd64.deb" \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@245
PS1, Line 245: "https://launchpadlibrarian.net/380913641/openjdk-8-jre_8u181-b13-0ubuntu0.16.04.1_amd64.deb" \
line too long (103 > 90)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@246
PS1, Line 246: "https://launchpadlibrarian.net/380913638/openjdk-8-jre-headless_8u181-b13-0ubuntu0.16.04.1_amd64.deb" \
line too long (112 > 90)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@247
PS1, Line 247: "https://launchpadlibrarian.net/380913642/openjdk-8-source_8u181-b13-0ubuntu0.16.04.1_all.deb" \
line too long (104 > 90)
http://gerrit.cloudera.org:8080/#/c/19908/1/bin/bootstrap_system.sh@248
PS1, Line 248: "https://launchpadlibrarian.net/380913633/openjdk-8-dbg_8u181-b13-0ubuntu0.16.04.1_amd64.deb"
line too long (101 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 May 2023 00:48:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9335/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 21 May 2023 00:48:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 21 May 2023 06:03:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13088/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 21 May 2023 01:08:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sun, 21 May 2023 14:00:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Revert "IMPALA-11253: Support testing with Java 11"
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19908 )
Change subject: Revert "IMPALA-11253: Support testing with Java 11"
......................................................................
Revert "IMPALA-11253: Support testing with Java 11"
This reverts commit ee6395db760e6629442c7e3fdda34519c61641c5 as it is
not flexible enough at detecting Java automatically in likely build
environments.
Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Reviewed-on: http://gerrit.cloudera.org:8080/19908
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
---
M CMakeLists.txt
M LICENSE.txt
M bin/bootstrap_system.sh
D bin/impala-config-java.sh
M bin/impala-config.sh
M bin/run-all-tests.sh
A cmake_modules/FindJNI.cmake
M fe/pom.xml
M fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java
M java/TableFlattener/pom.xml
M java/datagenerator/pom.xml
M java/executor-deps/pom.xml
M java/ext-data-source/api/pom.xml
M java/ext-data-source/sample/pom.xml
M java/ext-data-source/test/pom.xml
M java/query-event-hook-api/pom.xml
M java/shaded-deps/hive-exec/pom.xml
M java/shaded-deps/s3a-aws-sdk/pom.xml
M java/test-corrupt-hive-udfs/pom.xml
M java/test-hive-udfs/pom.xml
M java/yarn-extras/pom.xml
M testdata/bin/run-mini-dfs.sh
M testdata/bin/run-ranger-server.sh
D tests/verifiers/test_banned_log_messages.py
24 files changed, 406 insertions(+), 217 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I836c9f7fd10740b15f7e40b2e7f889ac7ee61fc3
Gerrit-Change-Number: 19908
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>