[GitHub] logging-log4net pull request #7: Add log4net asp.net extension

[dpsenner <gi...@git.apache.org>]

GitHub user dpsenner opened a pull request:

    https://github.com/apache/logging-log4net/pull/7

    Add log4net asp.net extension

    This reopens the old pull request 32 and provides a place for discussion. It would be nice to have some feedback from the author of the original patch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/logging-log4net pr/old/32

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4net/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #7
    
----
commit 3f428edaf7a82ab6091b216039debd94db729bd1
Author: Peter Jas <ne...@yahoo.com>
Date:   2016-08-21T00:14:53Z

    Add extension source project

commit 5e667994dd8bed50087b1948d4550d5f6e95aaac
Author: Peter Jas <ne...@yahoo.com>
Date:   2016-08-21T00:51:56Z

    Add test web app for asp extension

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

[dpsenner <gi...@git.apache.org>]

Github user dpsenner commented on the issue:

    https://github.com/apache/logging-log4net/pull/7
  
    There are issues preventing this:
    
    1. conflicting files that need to be solved
    1. the asf requires the author of "large changes" to sign an [individual contributor license agreement](https://www.apache.org/licenses/icla.pdf)
    
    After looking at the codebase in the pull request I further see the following:
    1. even though there is a test web app, there are no unit tests covering the addition. this new code needs unit tests.
    
    Feel free to pick up any of that work.


---

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

[dpsenner <gi...@git.apache.org>]

Github user dpsenner commented on the issue:

    https://github.com/apache/logging-log4net/pull/7
  
    We need an ICLA from the author Peter Jas since this is a rather large change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

[jvz <gi...@git.apache.org>]

Github user jvz commented on the issue:

    https://github.com/apache/logging-log4net/pull/7
  
    Would it be worth creating a software grant as well if an ICLA doesn't already exist?


---

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

[dpsenner <gi...@git.apache.org>]

Github user dpsenner commented on the issue:

    https://github.com/apache/logging-log4net/pull/7
  
    For the readers not knowing about what a software grant is, follow [this link](http://www.apache.org/licenses/proposed/software-grant.txt).
    
    A software grant may be desirable, given that this is a complete and working application. But it entirely depends on what the original author of the contribution likes to do.


---

[GitHub] logging-log4net issue #7: Add log4net asp.net extension

[saeidehv <gi...@git.apache.org>]

Github user saeidehv commented on the issue:

    https://github.com/apache/logging-log4net/pull/7
  
    Hi,
    Will this PR be available in the next release of log4net? Is there any estimation for release date?
    Thanks,


---