You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Martin Zink (Code Review)" <ge...@cloudera.org> on 2020/05/29 11:56:45 UTC
[Impala-ASF-CR] IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW LOGICAL OR) creates CompoundVe
Martin Zink has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/15877 )
Change subject: IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens. -OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands) -|| (KW_LOGICAL_OR) creates CompoundVe
......................................................................
IMPALA-452 Add support for string concatenation operator using || construct Separated "||" and "OR" into different tokens.
-OR (KW_OR) remains the same. (it creates CompoundPredicate and expects two BOOLEAN operands)
-|| (KW_LOGICAL_OR) creates CompoundVerticalBarExpr which expects two BOOLEAN operands or two STRING operands
CompoundVerticalBarExpr creates either a CompoundPredicate or a FunctionCallExpr member variable based on the type of the left operand during analyze.
CompoundVerticalBarExpr similarly to BetweenPredicate cannot be executed directly
so its needs to be replaced by its member variable by ExtractCompoundVerticalBarExprRule.
Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
---
M be/src/exprs/expr-test.cc
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
A fe/src/main/java/org/apache/impala/analysis/CompoundVerticalBarExpr.java
A fe/src/main/java/org/apache/impala/rewrite/ExtractCompoundVerticalBarExprRule.java
M fe/src/main/jflex/sql-scanner.flex
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M testdata/workloads/functional-query/queries/QueryTest/exprs.test
10 files changed, 240 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/77/15877/6
--
To view, visit http://gerrit.cloudera.org:8080/15877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3f990d56ecb1e18d1b2737e8c5eab0d524edfaf
Gerrit-Change-Number: 15877
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Zink <ma...@protonmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>