You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/02/26 13:53:55 UTC

[GitHub] [incubator-inlong] gosonzhang commented on pull request #2745: modify the field javadoc

gosonzhang commented on pull request #2745:
URL: https://github.com/apache/incubator-inlong/pull/2745#issuecomment-1052132036


   @yimaixinchen, first of all, thanks for your contribution
   
   This is a matter of code style and default conventions. I like to use "//" for variable annotations and /** */ for APIs, the main reason is that most of the variables can be explained in one sentence, while the API has parameters and core logic explanations, at least more lines can explain it clearly; Furthermore if the variables are commented with /** */, it will form a relatively large number of lines of code expansion problem.
   
   So this PR personally thinks it is not suitable for merging


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org