You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by cai shuhua <ca...@163.com> on 2018/06/12 20:12:48 UTC
Review Request 67558: Cai change.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Cai change.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67558/diff/1/
Testing
-------
Thanks,
cai shuhua
Re: Review Request 67558: Cai change.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204706
-----------------------------------------------------------
The patch looks good to me!
Would you mind changing the commit message as: "Added <your name> to the contributor list."
- Gilbert Song
On June 12, 2018, 1:12 p.m., cai shuhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 1:12 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cai change.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cai shuhua
>
>
Re: Review Request 67558: Cai change.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204691
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67558]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 12, 2018, 8:12 p.m., cai shuhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 8:12 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cai change.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cai shuhua
>
>
Re: Review Request 67558: Cai change.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204651
-----------------------------------------------------------
PASS: Mesos patch 67558 was successfully built and tested.
Reviews applied: `['67558']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67558
- Mesos Reviewbot Windows
On June 12, 2018, 1:12 p.m., cai shuhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 1:12 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cai change.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cai shuhua
>
>
Re: Review Request 67558: Added Cai ShuHua to the contributor list.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/#review204983
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On June 18, 2018, 11:31 p.m., cai shuhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67558/
> -----------------------------------------------------------
>
> (Updated June 18, 2018, 11:31 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added Cai ShuHua to the contributor list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cai shuhua
>
>
Re: Review Request 67558: Added Cai ShuHua to the contributor list.
Posted by cai shuhua <ca...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/
-----------------------------------------------------------
(Updated June 18, 2018, 11:31 p.m.)
Review request for mesos and Gilbert Song.
Summary (updated)
-----------------
Added Cai ShuHua to the contributor list.
Repository: mesos
Description
-------
Added Cai ShuHua to the contributor list.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67558/diff/1/
Testing
-------
Thanks,
cai shuhua
Re: Review Request 67558: Cai change.
Posted by cai shuhua <ca...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/
-----------------------------------------------------------
(Updated 六月 14, 2018, 11:06 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description (updated)
-------
Added Cai ShuHua to the contributor list.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67558/diff/1/
Testing
-------
Thanks,
cai shuhua
Re: Review Request 67558: Cai change.
Posted by cai shuhua <ca...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67558/
-----------------------------------------------------------
(Updated 六月 14, 2018, 11:01 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description (updated)
-------
Added caishuhua916 to the contributor list.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67558/diff/1/
Testing
-------
Thanks,
cai shuhua