You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/02/23 03:19:27 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #40136: [SPARK-42515][BUILD][TESTS] Make `write table` in `ClientE2ETestSuite` local test pass
LuciferYang opened a new pull request, #40136:
URL: https://github.com/apache/spark/pull/40136
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115256951
##########
connector/connect/server/pom.xml:
##########
@@ -199,6 +199,11 @@
<version>${tomcat.annotations.api.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.parquet</groupId>
+ <artifactId>parquet-hadoop</artifactId>
+ <scope>provided</scope>
Review Comment:
`provided` scope still failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1447537692
Merged to master and branch-3.4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhenlineo commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "zhenlineo (via GitHub)" <gi...@apache.org>.
zhenlineo commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1116156560
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
I kind of understand the `SimpleSparkConnectService` started the test with the client classpath, but then the submit script should scan all spark dependencies independently. See this code in spark-class:
https://github.com/apache/spark/blob/master/bin/spark-class#L38-L43
These are the real jars that are pulled into the spark when starting. So I feel we should ensure the jars are put into these jar folders correctly instead of modifying the client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115315752
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
And when I revert to add `parquet-hadoop` as test dependency of `connect-client-jvm`, I found the `parquet-**.jar` in the `java.class.path`, so I think `SimpleSparkConnectService` startup use classpath base on `connect-client-jvm` now in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1447542446
Thanks @HyukjinKwon @hvanhovell @zhenlineo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1447459839
Thanks @zhenlineo friendly ping @HyukjinKwon @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1118213407
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
> On the other side, maven is so slow for me.
Yes, maven is slow, but we must also ensure `maven pack test` can pass without any preparation work, otherwise, they will become a block of new version release :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115253586
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Good question, when I add this to server side, the test still failed, I also think this is strange, let me think more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1447460558
A Ga task failed, let me re-trigger it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1116486039
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
both `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars` and `"${SPARK_HOME}/jars"` not exists. the new commit make `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars` has content.
But this makes the module test more heavier ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
URL: https://github.com/apache/spark/pull/40136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115305918
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Did an experiment
https://github.com/apache/spark/blob/eb24dbd305b9e46382d49d43202d0c3a89fd324f/connector/connect/server/src/main/scala/org/apache/spark/sql/connect/SimpleSparkConnectService.scala#L40-L44
`System.getProperty("java.class.path")` before `while (true) {` and print the results: [SimpleSparkConnectService-classpath.txt](https://github.com/apache/spark/files/10811046/SimpleSparkConnectService-classpath.txt), there is no jar related to `parquet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
URL: https://github.com/apache/spark/pull/40136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1118209034
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
> Do we still need rules for the following two jars?
>
> ```
> (LocalProject("connect") / assembly).value
> (LocalProject("connect-client-jvm") / assembly).value
> ```
>
> These two jars are not included in `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars`.
>
> Is it slow for you to run sbt package to run this test? I get the impression it takes ~1min to run the first time? On the other side, maven is so slow for me.
No longer needed, `sql`, `assembly ` will trigger their build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhenlineo commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "zhenlineo (via GitHub)" <gi...@apache.org>.
zhenlineo commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1116496074
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Do we still need rules for the following two jars?
```
(LocalProject("connect") / assembly).value
(LocalProject("connect-client-jvm") / assembly).value
```
These two jars are not included in `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars`.
Is it slow for you to run sbt package to run this test? I get the impression it takes ~1min to run the first time? On the other side, maven is so slow for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115328475
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Or do you have any suggestions to correct the startup classpath of `SimpleSparkConnectService`? @hvanhovell @zhenlineo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1118209034
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
> Do we still need rules for the following two jars?
>
> ```
> (LocalProject("connect") / assembly).value
> (LocalProject("connect-client-jvm") / assembly).value
> ```
>
> These two jars are not included in `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars`.
>
> Is it slow for you to run sbt package to run this test? I get the impression it takes ~1min to run the first time? On the other side, maven is so slow for me.
No longer needed, `assembly ` will trigger build of `connect-client-jvm"`, `connect`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115214435
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
I have trouble understanding how adding this to the client influences the server to do the right thing? Could you help me understand?
cc @zhenlineo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1441185226
cc @hvanhovell
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115273797
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Yeah, even if I make `parquet-hadoop` as the compile dependency of the `server` module(but exclude `parquet-` from the SBT assembly), this test will still fail.
So I think this issue is is related to the startup class path used for `SimpleSparkConnectService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115273797
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Even if I make `parquet-hadoop` as the compile dependency of the `server` module(but exclude `parquet-` from the SBT assembly), this test will still fail.
So I think this issue is is related to the startup class path used for `SimpleSparkConnectService`.
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Even if I make `parquet-hadoop` as the compile scope dependency of the `server` module(but exclude `parquet-` from the SBT assembly), this test will still fail.
So I think this issue is is related to the startup class path used for `SimpleSparkConnectService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115328475
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Or do you have any suggestions to correct the startup classpath of `SimpleSparkConnectService`? @hvanhovell @zhenlineo
PS: make `parquet-hadoop` as compile dependency of `connect` server module and allow it to be assembly in `spark-connect-assembly-3.5.0-SNAPSHOT.jar` can also workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115318339
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
So I think `parquet-hadoop` is added to `connect-client-jvm` module instead of `connect` server module because `SimpleSparkConnectService` is started using the test classpath of `connect-client-jvm` module currently .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1118213407
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
> On the other side, maven is so slow for me.
Yes, maven is slow, but we must also ensure `maven pack test` can pass without any preparation work, otherwise, they will become a block of new version release :) (see dev mail list for details)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1118212051
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
Update comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115315752
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
And when I revert to add `parquet-hadoop` as test dependency of `connect-client-jvm`, I found the `parquet-**.jar` in the `java.class.path`, so I think `SimpleSparkConnectService` startup use classpath base on `connect-client-jvm` now in this scenario.
[SimpleSparkConnectService-new-classpath.txt](https://github.com/apache/spark/files/10811251/SimpleSparkConnectService-new-classpath.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115315752
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
And when I revert to add `parquet-hadoop` as test dependency of `connect-client-jvm`, I found the `parquet-**.jar` in the `java.class.path`, so I think `SimpleSparkConnectService` startup use classpath of `connect-client-jvm` now in this scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1115318339
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
So I think `parquet-hadoop` is added to `connect-client-jvm` module instead of `connect` server module because `SimpleSparkConnectService` is started using the test classpath base on `connect-client-jvm` module currently .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40136:
URL: https://github.com/apache/spark/pull/40136#issuecomment-1443787996
Is the fix feasible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #40136: [SPARK-42515][BUILD][CONNECT][TESTS] Make `write table` in `ClientE2ETestSuite` sbt local test pass
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #40136:
URL: https://github.com/apache/spark/pull/40136#discussion_r1116486039
##########
connector/connect/client/jvm/pom.xml:
##########
@@ -125,6 +125,11 @@
<version>${mima.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
both `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars` and `SPARK_JARS_DIR="${SPARK_HOME}/jars"` not exists. the new commit make `${SPARK_HOME}/assembly/target/scala-$SPARK_SCALA_VERSION/jars` has content.
But this makes the module test more heavier ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org