You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/07/15 03:47:24 UTC
Review Request 36495: Implemented the RESCIND Event handler in the
scheduler driver.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36495/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2910
https://issues.apache.org/jira/browse/MESOS-2910
Repository: mesos
Description
-------
See above.
Diffs
-----
src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f
src/tests/scheduler_event_call_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36495/diff/
Testing
-------
Added a test.
Thanks,
Ben Mahler
Re: Review Request 36495: Implemented the RESCIND Event handler in the
scheduler driver.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36495/#review91929
-----------------------------------------------------------
Ship it!
src/sched/sched.cpp (line 469)
<https://reviews.apache.org/r/36495/#comment145661>
Add a TODO here to refactor.
src/tests/scheduler_event_call_tests.cpp (line 85)
<https://reviews.apache.org/r/36495/#comment145659>
ditto. comment.
- Vinod Kone
On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36495/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 1:47 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2910
> https://issues.apache.org/jira/browse/MESOS-2910
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See above.
>
>
> Diffs
> -----
>
> src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f
> src/tests/scheduler_event_call_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36495/diff/
>
>
> Testing
> -------
>
> Added a test.
>
>
> Thanks,
>
> Ben Mahler
>
>