You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/19 13:30:37 UTC
[PR] fix(alert): match literal rule search text [rocketmq-dashboard]
Loyal-Young opened a new pull request, #7086:
URL: https://github.com/apache/rocketmq-dashboard/pull/7086
## Summary
- Escape SQL `LIKE` metacharacters in both alert-rule list searches.
- Preserve the existing name/metric, enabled, and domain filters.
- Add bound-query tests for literal `%`, `_`, and backslashes.
Fixes #7084.
## Verification
- `MybatisPlusAlertRepositoryTest`: 20 tests passed on JDK 21 / Maven 3.9.9.
- `git diff --check` passed.
## AI assistance
I used AI assistance to inspect both alert-rule query paths and draft the regression cases. I reviewed the patch and ran the focused Java test class locally; I will follow up on CI and reviewer feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): match literal rule search text [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7086:
URL: https://github.com/apache/rocketmq-dashboard/pull/7086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alert): match literal rule search text [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #7086:
URL: https://github.com/apache/rocketmq-dashboard/pull/7086#issuecomment-6285821664
CI update: the Frontend Build failure is in ConsumerPage.test.tsx (modal refresh/stack assertions), outside this PR's alert repository query and tests. The real-timer race is documented with a pending test-only fix in #5626. MybatisPlusAlertRepositoryTest passed locally (20/20), and the four other CI jobs passed; I will recheck CI after the shared test fix lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org