You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2010/08/11 21:05:17 UTC

[jira] Created: (DROIDS-99) Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability

Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability
------------------------------------------------------------------------------------

                 Key: DROIDS-99
                 URL: https://issues.apache.org/jira/browse/DROIDS-99
             Project: Droids
          Issue Type: Improvement
          Components: core
    Affects Versions: 0.0.1
            Reporter: Eugen Paraschiv
            Priority: Minor
             Fix For: 0.0.1


The only responsibility of this validator is to validate according to a maximum allowed depth of a Task, so it should be renamed to reflect this fact. My suggestion is MaxDepthTaskValidator as one of many validators to make their way into Droids. I have attached a patch for this change. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (DROIDS-99) Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability

Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugen Paraschiv updated DROIDS-99:
----------------------------------

    Attachment: validator_rename.patch

> Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability
> ------------------------------------------------------------------------------------
>
>                 Key: DROIDS-99
>                 URL: https://issues.apache.org/jira/browse/DROIDS-99
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>            Priority: Minor
>             Fix For: 0.0.1
>
>         Attachments: validator_rename.patch
>
>
> The only responsibility of this validator is to validate according to a maximum allowed depth of a Task, so it should be renamed to reflect this fact. My suggestion is MaxDepthTaskValidator as one of many validators to make their way into Droids. I have attached a patch for this change. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (DROIDS-99) Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability

Posted by "Javier Puerto (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DROIDS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898564#action_12898564 ] 

Javier Puerto commented on DROIDS-99:
-------------------------------------

Thanks Eugen.

Commited revision: r985457

> Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability
> ------------------------------------------------------------------------------------
>
>                 Key: DROIDS-99
>                 URL: https://issues.apache.org/jira/browse/DROIDS-99
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>            Priority: Minor
>             Fix For: 0.0.1
>
>         Attachments: validator_rename.patch
>
>
> The only responsibility of this validator is to validate according to a maximum allowed depth of a Task, so it should be renamed to reflect this fact. My suggestion is MaxDepthTaskValidator as one of many validators to make their way into Droids. I have attached a patch for this change. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (DROIDS-99) Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability

Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DROIDS-99?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugen Paraschiv resolved DROIDS-99.
-----------------------------------

    Resolution: Fixed

> Rename SimpleTaskValidator to MaxDepthTaskValidator according to it's responsability
> ------------------------------------------------------------------------------------
>
>                 Key: DROIDS-99
>                 URL: https://issues.apache.org/jira/browse/DROIDS-99
>             Project: Droids
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.0.1
>            Reporter: Eugen Paraschiv
>            Priority: Minor
>             Fix For: 0.0.1
>
>         Attachments: validator_rename.patch
>
>
> The only responsibility of this validator is to validate according to a maximum allowed depth of a Task, so it should be renamed to reflect this fact. My suggestion is MaxDepthTaskValidator as one of many validators to make their way into Droids. I have attached a patch for this change. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.