You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/02 12:45:39 UTC
[GitHub] [hudi] wangxianghu opened a new pull request #2139: [HUDI-1313] Rename hudi-spark-client module to hudi-client-spark
wangxianghu opened a new pull request #2139:
URL: https://github.com/apache/hudi/pull/2139
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
## What is the purpose of the pull request
*Rename hudi-spark-client module to hudi-client-spark*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu closed pull request #2139: [HUDI-1313] Rename hudi-spark-client module to hudi-client-spark
Posted by GitBox <gi...@apache.org>.
wangxianghu closed pull request #2139:
URL: https://github.com/apache/hudi/pull/2139
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] wangxianghu commented on pull request #2139: [HUDI-1313] Rename hudi-spark-client module to hudi-client-spark
Posted by GitBox <gi...@apache.org>.
wangxianghu commented on pull request #2139:
URL: https://github.com/apache/hudi/pull/2139#issuecomment-703021700
> @wangxianghu I did not end up doing this in my pr because hudi-sync is alreadynamed in the same way. We can leave this also as-is?
Yes, I named it as `hudi-spark-client` refer to `hudi-sync` too. Since you also have this idea, let's leave it as `hudi-spark-client`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #2139: [HUDI-1313] Rename hudi-spark-client module to hudi-client-spark
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #2139:
URL: https://github.com/apache/hudi/pull/2139#issuecomment-702871683
@wangxianghu I did not end up doing this in my pr because hudi-sync is alreadynamed in the same way. We can leave this also as-is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org