You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/06/18 09:18:05 UTC

[GitHub] [openwhisk-cli] jiangpengcheng commented on a change in pull request #485: remove trailing slash on apihost #481

jiangpengcheng commented on a change in pull request #485:
URL: https://github.com/apache/openwhisk-cli/pull/485#discussion_r442087872



##########
File path: commands/property.go
##########
@@ -471,6 +471,10 @@ func loadProperties() error {
 	}
 
 	if apiHost, hasProp := props["APIHOST"]; hasProp {
+		if last := len(apiHost) - 1; last >= 0 && apiHost[last] == '/' {

Review comment:
       how about using `Properties.APIHost = strings.TrimRight(apiHost, "/")` directly?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org