You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/04/18 21:29:21 UTC
[GitHub] [cordova-android] ath0mas opened a new pull request #1214: Fix how project name is set for Android Studio
ath0mas opened a new pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fix #1209 (Android Studio resets project name on Gradle reload)
### Description
<!-- Describe your changes in detail -->
Add `rootProject.name = "Hello World"` inside **settings.gradle** at root.
Remove _.idea/.name_ file previously added with #1173 and [v9.1.0](https://github.com/apache/cordova-android/blob/master/RELEASENOTES.md#910-apr-09-2021)
### Testing
<!-- Please describe in detail how you tested your changes. -->
`npm test` success + project creation, open and run from IDE into emulator
Fine on 10.0.0-dev and same for 9.2.0-dev π (would be nice to backport this into a 9.x fix release)
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas edited a comment on pull request #1214: (WIP) Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
ath0mas edited a comment on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-890556284
> * PR needs to be rebased with master.
> * `rootProject.name` becomes `undefined` when you run `cordova build android`.
> * If I change the project name in `config.xml` the project name is not updated.
- now rebased
- good catch, I will look at it (caused by changes merged recently)
- is that the case with the `.idea/.name` file on current master? can you describe the steps you follow please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on pull request #1214: (WIP) Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-890822565
You are right, it seems I missed ProjectBuilder constructor is more central than I thought and should not be modified.
I started to rework this PR to consider `build` and `prepare`, as much as `create` π .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1214: Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-822065125
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9c165cb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1214 +/- ##
=========================================
Coverage ? 71.91%
=========================================
Files ? 21
Lines ? 1688
Branches ? 0
=========================================
Hits ? 1214
Misses ? 474
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.00% <100.00%> (ΓΈ)` | |
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `75.00% <100.00%> (ΓΈ)` | |
| [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `100.00% <100.00%> (ΓΈ)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c165cb...09cef1d](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1214: fix: display project name in Android Studio
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-822065125
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1214](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ded6419) into [master](https://codecov.io/gh/apache/cordova-android/commit/5db850890d5c94f5fc3c0b90a02bfb0b251c0da1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5db8508) will **decrease** coverage by `0.09%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 73.25% 73.15% -0.10%
==========================================
Files 21 21
Lines 1645 1643 -2
==========================================
- Hits 1205 1202 -3
- Misses 440 441 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2NyZWF0ZS5qcw==) | `94.24% <ΓΈ> (-0.20%)` | :arrow_down: |
| [lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL3ByZXBhcmUuanM=) | `44.61% <0.00%> (-0.14%)` | :arrow_down: |
| [lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkZXJzL1Byb2plY3RCdWlsZGVyLmpz) | `73.24% <100.00%> (+0.34%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5db8508...ded6419](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on pull request #1214: (WIP) Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-890556284
> * PR needs to be rebased with master.
> * `rootProject.name` becomes `undefined` when you run `cordova build android`.
> * If I change the project name in `config.xml` the project name is not updated.
- now rebased
- good catch, I will look at it
- is that the case with the `.idea/.name` file on current master? can you describe the steps you follow please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1214: (WIP) Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-890721416
> (caused by changes merged recently)
Not sure what you mean by this because the issue existed in the PR, not from master or the rebase.
All you need to do is create a project with your PR and then run `cordova build android`. You will see it becomes `undefined`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1214: fix: display project name in Android Studio
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1214: Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-822065125
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9c165cb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1214 +/- ##
=========================================
Coverage ? 71.91%
=========================================
Files ? 21
Lines ? 1688
Branches ? 0
=========================================
Hits ? 1214
Misses ? 474
Partials ? 0
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL2xpYi9jcmVhdGUuanM=) | `94.00% <100.00%> (ΓΈ)` | |
| [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `75.00% <100.00%> (ΓΈ)` | |
| [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/1214/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `100.00% <100.00%> (ΓΈ)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c165cb...09cef1d](https://codecov.io/gh/apache/cordova-android/pull/1214?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ath0mas commented on pull request #1214: Fix how project name is set for Android Studio
Posted by GitBox <gi...@apache.org>.
ath0mas commented on pull request #1214:
URL: https://github.com/apache/cordova-android/pull/1214#issuecomment-891102229
I push a new `cdv-gradle-name.gradle` file next to `settings.gradle`, that loads it,
and updated on `prepare` (so for `create` and `build` too) with every `<name>` change made in `config.xml`.
It deals with forbidden characters in gradle project name to prevent error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org