You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Igor Vaynberg (JIRA)" <ji...@apache.org> on 2008/06/03 19:08:45 UTC
[jira] Resolved: (WICKET-1682) HtmlHandler can't handle tags not
requiring closed tags if the tag names are uppercase
[ https://issues.apache.org/jira/browse/WICKET-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1682.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.4-M3
1.3.4
Assignee: Igor Vaynberg
> HtmlHandler can't handle tags not requiring closed tags if the tag names are uppercase
> --------------------------------------------------------------------------------------
>
> Key: WICKET-1682
> URL: https://issues.apache.org/jira/browse/WICKET-1682
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.3
> Reporter: Kent Tong
> Assignee: Igor Vaynberg
> Fix For: 1.3.4, 1.4-M3
>
>
> In HtmlHandler.java, the requiresCloseTag() method only looks the tag name in the Map, without considering the char case:
> public static boolean requiresCloseTag(final String name)
> {
> return doesNotRequireCloseTag.get(name) == null;
> }
> Because the keys are all lower case:
> static
> {
> // Tags which are allowed not be closed in HTML
> doesNotRequireCloseTag.put("p", Boolean.TRUE);
> doesNotRequireCloseTag.put("br", Boolean.TRUE);
> doesNotRequireCloseTag.put("img", Boolean.TRUE);
> doesNotRequireCloseTag.put("input", Boolean.TRUE);
> doesNotRequireCloseTag.put("hr", Boolean.TRUE);
> doesNotRequireCloseTag.put("link", Boolean.TRUE);
> doesNotRequireCloseTag.put("meta", Boolean.TRUE);
> }
> it will fail if uppercase tag names are used in the markup.
> I've verified that it dies with the following simple markup:
> <html>
> <body>
> <BR>
> </body>
> </html>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.