[PR] Update GraphBinary/GraphSON model test coverage [tinkerpop]

["kenhuuu (via GitHub)" <gi...@apache.org>]

kenhuuu opened a new pull request, #3526:
URL: https://github.com/apache/tinkerpop/pull/3526

   These changes update the model tests by removing stale tests, adding more tests for existing types and new tests for newly supported types.
   
   For review, the tests themselves can probably largely be ignored. I was going to CTR this but I did change how CompositePDT works (uses typed Map now rather than plain JSON object) so I'm going to keep this open for a couple days in case anyone wants to look at that part in particular. If not, I'll likely just merge this in as a CTR.
   
   VOTE +1
   <!--
   Thanks for contributing! Reminders:
   + TARGET the earliest branch where you want the change
       3.7-dev -> 3.7.7 (non-breaking only)
       3.8-dev -> 3.8.2 (non-breaking only)
       master  -> 4.0.0
   + Committers will MERGE the PR forward to newer versions
   + ADD entry to the CHANGELOG.asciidoc for the targeted version
       Do not reference a JIRA number there
   + ADD JIRA number to title and link in description
   + PRs requires 3 +1s from committers OR
                  1 +1 and 7 day wait to merge.
   + MORE details: https://s.apache.org/rtnal
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update GraphBinary/GraphSON model test coverage [tinkerpop]

["xiazcy (via GitHub)" <gi...@apache.org>]

xiazcy commented on PR #3526:
URL: https://github.com/apache/tinkerpop/pull/3526#issuecomment-5024493365

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update GraphBinary/GraphSON model test coverage [tinkerpop]

["Cole-Greer (via GitHub)" <gi...@apache.org>]

Cole-Greer merged PR #3526:
URL: https://github.com/apache/tinkerpop/pull/3526


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update GraphBinary/GraphSON model test coverage [tinkerpop]

["Cole-Greer (via GitHub)" <gi...@apache.org>]

Cole-Greer commented on PR #3526:
URL: https://github.com/apache/tinkerpop/pull/3526#issuecomment-5017404137

   VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org