You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "nytai (via GitHub)" <gi...@apache.org> on 2023/04/06 05:18:51 UTC
[GitHub] [superset] nytai opened a new pull request, #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
nytai opened a new pull request, #23604:
URL: https://github.com/apache/superset/pull/23604
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #23604:
URL: https://github.com/apache/superset/pull/23604#discussion_r1159307910
##########
superset/reports/commands/execute.py:
##########
@@ -408,9 +408,11 @@ def _send(
try:
if app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"]:
logger.info(
- "Would send notification for alert %s, to %s",
+ "Would send notification for alert %s, to %s. "
+ "%s is enabled, set it to False to send notifications.",
self._report_schedule.name,
recipient.recipient_config_json,
+ app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"],
Review Comment:
Would this not produce `True is enabled, set it to False to send notifications.`, as that's the value of the config param, not it's name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a diff in pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
Posted by "nytai (via GitHub)" <gi...@apache.org>.
nytai commented on code in PR #23604:
URL: https://github.com/apache/superset/pull/23604#discussion_r1160309352
##########
superset/reports/commands/execute.py:
##########
@@ -408,9 +408,11 @@ def _send(
try:
if app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"]:
logger.info(
- "Would send notification for alert %s, to %s",
+ "Would send notification for alert %s, to %s. "
+ "%s is enabled, set it to False to send notifications.",
self._report_schedule.name,
recipient.recipient_config_json,
+ app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"],
Review Comment:
Yes, I thought I pushed a fix for that 😞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on a diff in pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
Posted by "nytai (via GitHub)" <gi...@apache.org>.
nytai commented on code in PR #23604:
URL: https://github.com/apache/superset/pull/23604#discussion_r1160309749
##########
superset/reports/commands/execute.py:
##########
@@ -408,9 +408,11 @@ def _send(
try:
if app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"]:
logger.info(
- "Would send notification for alert %s, to %s",
+ "Would send notification for alert %s, to %s. "
+ "%s is enabled, set it to False to send notifications.",
self._report_schedule.name,
recipient.recipient_config_json,
+ app.config["ALERT_REPORTS_NOTIFICATION_DRY_RUN"],
Review Comment:
... I pushed to the wrong remote. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23604:
URL: https://github.com/apache/superset/pull/23604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23604: fix: update log message for ALERT_REPORTS_NOTIFICATION_DRY_RUN
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23604:
URL: https://github.com/apache/superset/pull/23604#issuecomment-1498511596
## [Codecov](https://codecov.io/gh/apache/superset/pull/23604?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23604](https://codecov.io/gh/apache/superset/pull/23604?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2fdfab3) into [master](https://codecov.io/gh/apache/superset/commit/c5eecc7cc2da88b367bfc7636edb52e0ba117bae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5eecc7) will **decrease** coverage by `11.34%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2fdfab3 differs from pull request most recent head 532a5f8. Consider uploading reports for the commit 532a5f8 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23604 +/- ##
===========================================
- Coverage 67.72% 56.38% -11.34%
===========================================
Files 1916 1916
Lines 74051 74051
Branches 8040 8040
===========================================
- Hits 50153 41757 -8396
- Misses 21850 30246 +8396
Partials 2048 2048
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.68% <ø> (ø)` | |
| python | `58.97% <ø> (-23.45%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.64% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/23604?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `22.92% <ø> (-69.11%)` | :arrow_down: |
... and [301 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23604/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org