You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Tim McConnell (JIRA)" <ji...@apache.org> on 2008/11/11 21:19:44 UTC
[jira] Created: (GERONIMODEVTOOLS-532) Surface the publish timeout
time in the server properties tab like all the other publishing attributes
(e.g., publishing interval)
Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
----------------------------------------------------------------------------------------------------------------------------------
Key: GERONIMODEVTOOLS-532
URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
Project: Geronimo-Devtools
Issue Type: Bug
Components: eclipse-plugin
Affects Versions: 2.2.0, 2.1.4
Reporter: Tim McConnell
Assignee: Tim McConnell
Fix For: 2.2.0, 2.1.4
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMODEVTOOLS-532) Surface the publish timeout
time in the server properties tab like all the other publishing attributes
(e.g., publishing interval)
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Delos Dai updated GERONIMODEVTOOLS-532:
---------------------------------------
Attachment: 532.patch
> Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-532
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMODEVTOOLS-532) Surface the publish timeout
time in the server properties tab like all the other publishing attributes
(e.g., publishing interval)
Posted by "B.J. Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
B.J. Reed reassigned GERONIMODEVTOOLS-532:
------------------------------------------
Assignee: B.J. Reed (was: Tim McConnell)
> Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-532
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: Tim McConnell
> Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-532) Surface the publish
timeout time in the server properties tab like all the other publishing
attributes (e.g., publishing interval)
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12659776#action_12659776 ]
Delos Dai commented on GERONIMODEVTOOLS-532:
--------------------------------------------
In my opinion,it's better to add "publishing timeout" together with "publishing interval" in "publishing" section. However, "publishing" section is rendered by class OverviewEditorPart in org.eclipse.wst.server.ui, currently no extension point available to update this section. That means, "publishing" section is a built-in section of overview page for server properites.
So here are two option for this:
1) With extension point "org.eclipse.wst.server.ui.editorPageSections", a separated section including "publishing timeout" can be created and added into "Overview" page, just like "VM args" section and "Ports" section. In this way, the "publishing timeout" will be separated from "publishing" section.
2) Override the createPublishsection() in "OverviewEditorPart", which is used to render "publishing" section. In this way, "publishing timeout" can be added into the built-in "publishing" section. How to override? Now, "OverviewEditorPart" implement the overview page by contributing to extension point "org.eclipse.wst.server.ui.editorPages". The key to this method is we have to use the same page id as "OverviewEditorPart" when declaring our extension. Our extension can inherit "OverviewEditorPart" and override the method createPublishsection() of it.
I have implemented option 2 and attach the patch. Hope someone can help to review it.
Any comments?
Thanks!
> Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-532
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: Tim McConnell
> Assignee: Tim McConnell
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMODEVTOOLS-532) Surface the publish
timeout time in the server properties tab like all the other publishing
attributes (e.g., publishing interval)
Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661806#action_12661806 ]
Delos Dai commented on GERONIMODEVTOOLS-532:
--------------------------------------------
OK. Thanks a lot!
> Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-532
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: Tim McConnell
> Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMODEVTOOLS-532) Surface the publish timeout
time in the server properties tab like all the other publishing attributes
(e.g., publishing interval)
Posted by "B.J. Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
B.J. Reed resolved GERONIMODEVTOOLS-532.
----------------------------------------
Resolution: Fixed
fixed with r732383. Thanks Delos Dai for the patch. Unfortunately, we had to go with option 1 to fix this. Your patch created a second Server Overview page and we couldn't find a way to get rid of the first page.
There were a few things I noticed in the files you created. Try not to use tabs, use 4 spaces instead. Copy the license header from another file to put at the top of any new file. Also put the following in a comment so that versions will be kept track of:
@version $Rev$ $Date$
Thanks again.
> Surface the publish timeout time in the server properties tab like all the other publishing attributes (e.g., publishing interval)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: GERONIMODEVTOOLS-532
> URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-532
> Project: Geronimo-Devtools
> Issue Type: Bug
> Components: eclipse-plugin
> Affects Versions: 2.2.0, 2.1.4
> Reporter: Tim McConnell
> Assignee: B.J. Reed
> Fix For: 2.2.0, 2.1.4
>
> Attachments: 532.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.