You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@asterixdb.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:06:52 UTC
[GitHub] [asterixdb] parshimers commented on a change in pull request #15: Set proper inner dependency
parshimers commented on a change in pull request #15:
URL: https://github.com/apache/asterixdb/pull/15#discussion_r650439226
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
can this be ${parent.version} ? We always keep this module's versison the same as the parent's. If it's like this it would complicate the version increment process during releases.
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
and by "this" I mean <version>, sorry. I thought that comment would get inserted right at line 52.
##########
File path: asterixdb/asterix-doc/pom.xml
##########
@@ -45,6 +45,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-antrun-plugin</artifactId>
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.asterix</groupId>
+ <artifactId>asterix-lang-sqlpp</artifactId>
+ <version>0.9.6-SNAPSHOT</version>
Review comment:
and by "this" I mean \<version\>, sorry. I thought that comment would get inserted right at line 52.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org