You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/23 01:24:51 UTC
[GitHub] [spark] beliefer opened a new pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
beliefer opened a new pull request #29754:
URL: https://github.com/apache/spark/pull/29754
### What changes were proposed in this pull request?
TaskSchedulerImplSuite always check the results show below:
```
val zeroCoreWorkerOffers = IndexedSeq(new WorkerOffer("executor0", "host0", 0),
new WorkerOffer("executor1", "host1", 0))
val taskSet = FakeTask.createTaskSet(1)
taskScheduler.submitTasks(taskSet)
var taskDescriptions = taskScheduler.resourceOffers(zeroCoreWorkerOffers).flatten
assert(0 === taskDescriptions.length)
```
We can extract it as a generic method.
### Why are the changes needed?
Extract a generic method.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
Jenkins test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696554322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-803729987
cc @jiangxb1987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693276665
**[Test build #128759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128759/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737905827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692512935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692470147
**[Test build #128694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128694/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737856694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804790434
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692512308
**[Test build #128694 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128694/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735640736
**[Test build #131975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131975/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735640736
**[Test build #131975 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131975/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29754:
URL: https://github.com/apache/spark/pull/29754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737764917
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735704026
**[Test build #131975 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131975/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693277377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735696536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804616427
**[Test build #136373 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136373/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
* This patch **fails SparkR unit tests**.
* This patch **does not merge cleanly**.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692535334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804533704
> @beliefer , could you resolve the conflicts?
@dongido001 Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696553799
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-872622534
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804528702
**[Test build #136373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136373/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693277377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692512947
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128694/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692626784
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696627614
**[Test build #128971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128971/testReport)** for PR 29754 at commit [`57e8eb6`](https://github.com/apache/spark/commit/57e8eb696fe0243639db925ada8762f84369da00).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737823748
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36711/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492497147
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
+ taskSets: Seq[TaskSet] = Seq(FakeTask.createTaskSet(1)),
+ taskSchedulerOpt: Option[TaskSchedulerImpl] = None) (f: Seq[TaskDescription] => Any): Any = {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804790434
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804560380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40959/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692512935
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737905827
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692626115
**[Test build #128705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128705/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692626784
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #29754:
URL: https://github.com/apache/spark/pull/29754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693275407
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696554322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696554322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-803695376
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804549509
**[Test build #136378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136378/testReport)** for PR 29754 at commit [`f5229e6`](https://github.com/apache/spark/commit/f5229e622ce9f729050068fc65ecf55caff37978).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804560299
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40959/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735704793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804790798
cc @jiangxb1987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696628575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693365930
**[Test build #128759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128759/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692451753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696553799
**[Test build #128971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128971/testReport)** for PR 29754 at commit [`57e8eb6`](https://github.com/apache/spark/commit/57e8eb696fe0243639db925ada8762f84369da00).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737774680
**[Test build #132112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132112/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692535334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692534728
**[Test build #128705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128705/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804620822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804636621
**[Test build #136378 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136378/testReport)** for PR 29754 at commit [`f5229e6`](https://github.com/apache/spark/commit/f5229e622ce9f729050068fc65ecf55caff37978).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696553799
**[Test build #128971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128971/testReport)** for PR 29754 at commit [`57e8eb6`](https://github.com/apache/spark/commit/57e8eb696fe0243639db925ada8762f84369da00).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492469232
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
+ taskSets: Seq[TaskSet] = Seq(FakeTask.createTaskSet(1)),
+ taskSchedulerOpt: Option[TaskSchedulerImpl] = None) (f: Seq[TaskDescription] => Any): Any = {
Review comment:
We can use the global `taskScheduler` as the default value?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
Review comment:
I found that many tests use the same WorkerOffer, e.g., `WorkerOffer("executor0", "host0", 1)`. Shall we make it as the default value as well?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1911,11 +1912,12 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
clock.advance(2000)
// Now give it some resources and both tasks should be rerun
- val taskDescriptions = taskScheduler.resourceOffers(IndexedSeq(
- WorkerOffer("executor2", "host2", 1), WorkerOffer("executor3", "host3", 1))).flatten
- assert(taskDescriptions.size === 2)
- assert(taskDescriptions.map(_.index).sorted == Seq(0, 1))
- assert(manager.copiesRunning.take(2) === Array(1, 1))
+ submitTasksAndCheck(IndexedSeq(WorkerOffer("executor2", "host2", 1),
+ WorkerOffer("executor3", "host3", 1)), Seq.empty) { taskDescriptions =>
Review comment:
Personally, I feel it's weird that we're submitting empty task sets here... `submitTasksAndCheck` maybe not appropriate for this case? Or you could redesign the `submitTasksAndCheck`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692534728
**[Test build #128705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128705/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696553799
**[Test build #128971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128971/testReport)** for PR 29754 at commit [`57e8eb6`](https://github.com/apache/spark/commit/57e8eb696fe0243639db925ada8762f84369da00).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737774680
**[Test build #132112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132112/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492497147
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
+ taskSets: Seq[TaskSet] = Seq(FakeTask.createTaskSet(1)),
+ taskSchedulerOpt: Option[TaskSchedulerImpl] = None) (f: Seq[TaskDescription] => Any): Any = {
Review comment:
OK
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
Review comment:
OK
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1911,11 +1912,12 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
clock.advance(2000)
// Now give it some resources and both tasks should be rerun
- val taskDescriptions = taskScheduler.resourceOffers(IndexedSeq(
- WorkerOffer("executor2", "host2", 1), WorkerOffer("executor3", "host3", 1))).flatten
- assert(taskDescriptions.size === 2)
- assert(taskDescriptions.map(_.index).sorted == Seq(0, 1))
- assert(manager.copiesRunning.take(2) === Array(1, 1))
+ submitTasksAndCheck(IndexedSeq(WorkerOffer("executor2", "host2", 1),
+ WorkerOffer("executor3", "host3", 1)), Seq.empty) { taskDescriptions =>
Review comment:
OK. Let's not change this matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-716476427
cc @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737889451
**[Test build #132112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132112/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804560380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40959/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692532672
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-742182561
cc @jiangxb1987
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804620826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804645451
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136378/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804616758
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804514855
Since the author (@beliefer ) is active, I removed the `Stale` tag and reopen this PR.
@beliefer , could you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735696536
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693367041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804548623
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40959/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696628575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693276665
**[Test build #128759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128759/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737856438
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36711/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692470147
**[Test build #128694 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/128694/testReport)** for PR 29754 at commit [`4240990`](https://github.com/apache/spark/commit/42409905619a5035d962a207f5702e1e2a63c739).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492469232
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
+ taskSets: Seq[TaskSet] = Seq(FakeTask.createTaskSet(1)),
+ taskSchedulerOpt: Option[TaskSchedulerImpl] = None) (f: Seq[TaskDescription] => Any): Any = {
Review comment:
We can use the global `taskScheduler` as the default value?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
Review comment:
I found that many tests use the same WorkerOffer, e.g., `WorkerOffer("executor0", "host0", 1)`. Shall we make it as the default value as well?
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1911,11 +1912,12 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
clock.advance(2000)
// Now give it some resources and both tasks should be rerun
- val taskDescriptions = taskScheduler.resourceOffers(IndexedSeq(
- WorkerOffer("executor2", "host2", 1), WorkerOffer("executor3", "host3", 1))).flatten
- assert(taskDescriptions.size === 2)
- assert(taskDescriptions.map(_.index).sorted == Seq(0, 1))
- assert(manager.copiesRunning.take(2) === Array(1, 1))
+ submitTasksAndCheck(IndexedSeq(WorkerOffer("executor2", "host2", 1),
+ WorkerOffer("executor3", "host3", 1)), Seq.empty) { taskDescriptions =>
Review comment:
Personally, I feel it's weird that we're submitting empty task sets here... `submitTasksAndCheck` maybe not appropriate for this case? Or you could redesign the `submitTasksAndCheck`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804528702
**[Test build #136373 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136373/testReport)** for PR 29754 at commit [`15c63c3`](https://github.com/apache/spark/commit/15c63c3b7964982a468b50fad5768bf0ea612fe2).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692626788
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/128705/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-737856694
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804645451
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136378/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804549509
**[Test build #136378 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136378/testReport)** for PR 29754 at commit [`f5229e6`](https://github.com/apache/spark/commit/f5229e622ce9f729050068fc65ecf55caff37978).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-696554322
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-804606349
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-693367041
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-735704793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29754: [WIP][SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29754:
URL: https://github.com/apache/spark/pull/29754#issuecomment-692451753
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492519743
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -1911,11 +1912,12 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
clock.advance(2000)
// Now give it some resources and both tasks should be rerun
- val taskDescriptions = taskScheduler.resourceOffers(IndexedSeq(
- WorkerOffer("executor2", "host2", 1), WorkerOffer("executor3", "host3", 1))).flatten
- assert(taskDescriptions.size === 2)
- assert(taskDescriptions.map(_.index).sorted == Seq(0, 1))
- assert(manager.copiesRunning.take(2) === Array(1, 1))
+ submitTasksAndCheck(IndexedSeq(WorkerOffer("executor2", "host2", 1),
+ WorkerOffer("executor3", "host3", 1)), Seq.empty) { taskDescriptions =>
Review comment:
OK. Let's not change this matter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #29754: [SPARK-32875][CORE][TEST] TaskSchedulerImplSuite: For the pattern of submitTasks + resourceOffers + assert, extract the general method.
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #29754:
URL: https://github.com/apache/spark/pull/29754#discussion_r492500277
##########
File path: core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala
##########
@@ -140,6 +140,16 @@ class TaskSchedulerImplSuite extends SparkFunSuite with LocalSparkContext with B
taskScheduler
}
+ private def submitTasksAndCheck(
+ offers: IndexedSeq[WorkerOffer],
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org