You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mercyblitz (GitHub)" <gi...@apache.org> on 2020/02/06 09:16:20 UTC
[GitHub] [dubbo] mercyblitz opened pull request #5454: [Dubbo-5446]
fix aop issue with @Reference
## What is the purpose of the change
Fix [issue#5446](https://github.com/apache/dubbo/issues/5446)
I think using bean from spring instead of ref object for injection can better supports AOP or other extended operations
## Brief changelog
**org.apache.dubbo.config.spring.beans.factory.annotation.ReferenceAnnotationBeanPostProcessor**
## Verifying this change
pass **ReferenceAnnotationBeanPostProcessorTest**
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5454 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] GungnirLaevatain commented on issue #5454: Fix
issue#5446
Posted by "GungnirLaevatain (GitHub)" <gi...@apache.org>.
@mercyblitz PTAL,thanks
[ Full content available at: https://github.com/apache/dubbo/pull/5454 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5454: [Dubbo-5446]
fix aop issue with @Reference
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=h1) Report
> Merging [#5454](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/8eae30105ca005374683433964318b667d0c290c?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `90%`.
[](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5454 +/- ##
============================================
- Coverage 61.23% 61.04% -0.19%
+ Complexity 424 422 -2
============================================
Files 919 919
Lines 37520 37536 +16
Branches 5462 5463 +1
============================================
- Hits 22975 22914 -61
- Misses 12036 12114 +78
+ Partials 2509 2508 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...notation/ReferenceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvYmVhbnMvZmFjdG9yeS9hbm5vdGF0aW9uL1JlZmVyZW5jZUFubm90YXRpb25CZWFuUG9zdFByb2Nlc3Nvci5qYXZh) | `80.8% <90%> (+1.39%)` | `0 <0> (ø)` | :arrow_down: |
| [...rg/apache/dubbo/remoting/utils/PayloadDropper.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy91dGlscy9QYXlsb2FkRHJvcHBlci5qYXZh) | `46.15% <0%> (-23.08%)` | `0% <0%> (ø)` | |
| [...ubbo/registry/support/AbstractRegistryFactory.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnlGYWN0b3J5LmphdmE=) | `70.58% <0%> (-14.71%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/registry/dubbo/DubboRegistry.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktZGVmYXVsdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVnaXN0cnkvZHViYm8vRHViYm9SZWdpc3RyeS5qYXZh) | `56.86% <0%> (-11.77%)` | `10% <0%> (-1%)` | |
| [...o/rpc/cluster/support/wrapper/AbstractCluster.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC93cmFwcGVyL0Fic3RyYWN0Q2x1c3Rlci5qYXZh) | `62.16% <0%> (-10.82%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC9Bc3luY1RvU3luY0ludm9rZXIuamF2YQ==) | `70.83% <0%> (-8.34%)` | `0% <0%> (ø)` | |
| [...interceptor/ConsumerContextClusterInterceptor.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvaW50ZXJjZXB0b3IvQ29uc3VtZXJDb250ZXh0Q2x1c3RlckludGVyY2VwdG9yLmphdmE=) | `84.61% <0%> (-7.7%)` | `0% <0%> (ø)` | |
| [...he/dubbo/common/threadpool/ThreadlessExecutor.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGhyZWFkcG9vbC9UaHJlYWRsZXNzRXhlY3V0b3IuamF2YQ==) | `55.55% <0%> (-5.56%)` | `0% <0%> (ø)` | |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `63.8% <0%> (-4.11%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/remoting/transport/AbstractServer.java](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RTZXJ2ZXIuamF2YQ==) | `53.75% <0%> (-3.75%)` | `0% <0%> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/dubbo/pull/5454/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=footer). Last update [8eae301...f97d89f](https://codecov.io/gh/apache/dubbo/pull/5454?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5454 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] mercyblitz closed pull request #5454: [Dubbo-5446]
fix aop issue with @Reference
Posted by "mercyblitz (GitHub)" <gi...@apache.org>.
[ pull request closed by mercyblitz ]
[ Full content available at: https://github.com/apache/dubbo/pull/5454 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org